Switch to go1.11 #22510

Closed

soltysh wants to merge 1 commit intoopenshift:masterfrom

Contributor

soltysh commented Apr 9, 2019 •

edited

Loading

Followup to #22523
/assign @smarterclayton

openshift-ci-robot assigned smarterclayton

openshift-ci-robot added the size/XL label

openshift-ci-robot requested review from bparees and csrwng

April 9, 2019 09:55

soltysh mentioned this pull request

Switch origin to go1.11 openshift/release#3394

Merged

Contributor

bparees commented Apr 9, 2019

@soltysh seems worthy of an aos-devel announcement.

Contributor Author

soltysh commented Apr 9, 2019

@bparees there will be one when we'll be close, it's a few days away still, just starting 😉

smarterclayton reviewed

View reviewed changes

origin.spec

               %global import_path github.com/openshift/origin
-              %global golang_version 1.10
+              %global golang_version 1.11

Contributor

smarterclayton Apr 9, 2019

Check with @sosiouxme on this change

Contributor

smarterclayton Apr 9, 2019

You probably will have to open a pr to ocp-build-data

Contributor Author

soltysh Apr 9, 2019

Will do.

Contributor Author

soltysh Apr 10, 2019

It's already there.

Member

sosiouxme Apr 17, 2019

apparently i forgot to comment here.
the spec file requesting 1.11 should suffice to get it.
image configs in ocp-build-data should already be updated for when this lands.

Contributor

smarterclayton commented Apr 9, 2019

/retest

1 similar comment

Contributor

smarterclayton commented Apr 10, 2019

/retest


          Switch to go1.11

fc359a0

soltysh force-pushed the go1.11 branch from f0f1eef to fc359a0 Compare

April 10, 2019 09:38

openshift-ci-robot added size/S and removed size/XL labels

openshift-ci-robot commented Apr 10, 2019 •

edited

Loading

@soltysh: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-builds	`fc359a0`	link	`/test e2e-aws-builds`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor Author

soltysh commented Apr 10, 2019

/retest

Member

sosiouxme commented Apr 10, 2019

should be fine in OCP. go-toolset-1.11 and shim are available.

Contributor

smarterclayton commented Apr 16, 2019

/lgtm
/approve

openshift-ci-robot added the lgtm label

Contributor Author

soltysh commented Apr 16, 2019

/retest

openshift-ci-robot commented Apr 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the approved label

Contributor Author

soltysh commented Apr 16, 2019

/retest

Contributor

openshift-bot commented Apr 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments

Contributor

openshift-bot commented Apr 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor Author

soltysh commented Apr 24, 2019

Hmmm... none of the failures seems related to this PR in particular. Most of them are related to unauthorized errors, none of which are coming from these changes.
/hold cancel
/retest

openshift-ci-robot removed the do-not-merge/hold label

Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

21 similar comments

Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor Author

soltysh commented Apr 25, 2019

/hold

openshift-ci-robot added the do-not-merge/hold label

soltysh mentioned this pull request

Switch to go1.11 #22666

Merged

Contributor Author

soltysh commented Apr 26, 2019

Closing in favor of #22666.

soltysh closed this

soltysh deleted the go1.11 branch

April 26, 2019 09:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved do-not-merge/hold lgtm size/S