Skip to content

Bump to get scheduler api updates#23368

Closed
ravisantoshgudimetla wants to merge 2 commits intoopenshift:masterfrom
ravisantoshgudimetla:bump-new-api
Closed

Bump to get scheduler api updates#23368
ravisantoshgudimetla wants to merge 2 commits intoopenshift:masterfrom
ravisantoshgudimetla:bump-new-api

Conversation

@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor

@ravisantoshgudimetla ravisantoshgudimetla commented Jul 11, 2019

This gets the MastersSchedulable field in scheduler Spec along with glide fix that I tried locally.

/cc @deads2k @sttts

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 11, 2019
@sttts
Copy link
Copy Markdown
Contributor

sttts commented Jul 12, 2019

/retest
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 12, 2019
@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor Author

/retest

@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor Author

I think the issue is related to this openshift/api#372, bumping in and testing locally.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2019
@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor Author

/test e2e-aws

@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor Author

/retest

@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor Author

/test images

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Jul 15, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2019
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ravisantoshgudimetla, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Copy Markdown

@ravisantoshgudimetla: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2019
@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor Author

614499f brought in what we wanted, so closing this PR

/close

@openshift-ci-robot
Copy link
Copy Markdown

@ravisantoshgudimetla: Closed this PR.

Details

In response to this:

614499f brought in what we wanted, so closing this PR

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants