Skip to content

Add repo details for disconnected install/upgrade#23381

Closed
mtnbikenc wants to merge 4 commits intoopenshift:masterfrom
mtnbikenc:repo-details
Closed

Add repo details for disconnected install/upgrade#23381
mtnbikenc wants to merge 4 commits intoopenshift:masterfrom
mtnbikenc:repo-details

Conversation

@mtnbikenc
Copy link
Copy Markdown
Member

@mtnbikenc mtnbikenc commented Jul 15, 2019 •
edited
Loading

When performing a release mirror, provide details of repos where images
have been mirrored from to be used for disconnected install or upgrade.

https://jira.coreos.com/browse/CORS-1105

Command:

oc adm release mirror --from=registry.svc.ci.openshift.org/ocp/release:4.2 --to=registry.svc.ci.openshift.org/rteague-1/mirror-test

Example output:

To use the new mirrored release-image to install, provide the following list of release-image sources to the installer using the install-config.yaml:

imageContentSources:
- sources:
  - registry.svc.ci.openshift.org/rteague-1/mirror-test
  - registry.svc.ci.openshift.org/ocp/release
  - quay.io/openshift-release-dev/ocp-v4.0-art-dev

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 15, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtnbikenc
To complete the pull request process, please assign mfojtik
You can assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtnbikenc
Copy link
Copy Markdown
Member Author

mtnbikenc commented Jul 15, 2019

/cc @abhinavdahiya

@abhinavdahiya
Copy link
Copy Markdown
Contributor

abhinavdahiya commented Jul 15, 2019

Can you provide the example output for the changeset..

abhinavdahiya
abhinavdahiya reviewed Jul 15, 2019
View reviewed changes
Comment thread staging/src/github.com/openshift/oc/pkg/cli/admin/release/mirror.go Outdated
abhinavdahiya
abhinavdahiya reviewed Jul 15, 2019
View reviewed changes
Comment thread staging/src/github.com/openshift/oc/pkg/cli/admin/release/mirror.go Outdated
abhinavdahiya
abhinavdahiya reviewed Jul 15, 2019
View reviewed changes
Comment thread staging/src/github.com/openshift/oc/pkg/cli/admin/release/mirror.go Outdated
abhinavdahiya
abhinavdahiya reviewed Jul 15, 2019
View reviewed changes
Comment thread staging/src/github.com/openshift/oc/pkg/cli/admin/release/mirror.go Outdated
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 16, 2019
@mtnbikenc
Copy link
Copy Markdown
Member Author

mtnbikenc commented Jul 16, 2019

@abhinavdahiya Updated with types to marshal the yaml output and broke out the code into a function.

mtnbikenc
mtnbikenc commented Jul 16, 2019
View reviewed changes
Comment thread staging/src/github.com/openshift/oc/pkg/cli/admin/release/mirror.go Outdated
mtnbikenc
mtnbikenc commented Jul 16, 2019
View reviewed changes
Comment thread staging/src/github.com/openshift/oc/pkg/cli/admin/release/mirror.go Outdated
@mtnbikenc mtnbikenc mentioned this pull request Jul 16, 2019
Merged
@mtnbikenc mtnbikenc changed the title [WIP] Add repo details for disconnected install/upgrade Add repo details for disconnected install/upgrade Jul 16, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2019
@mtnbikenc mtnbikenc force-pushed the repo-details branch 2 times, most recently from 93232de to 2681229 Compare July 16, 2019 17:45
@mtnbikenc
Copy link
Copy Markdown
Member Author

mtnbikenc commented Jul 16, 2019

Updated to imageContentSources

@abhinavdahiya
Copy link
Copy Markdown
Contributor

abhinavdahiya commented Jul 16, 2019

/cc @smarterclayton

as you've done most of the oc adm release mirror

DanyC97
DanyC97 reviewed Jul 16, 2019
View reviewed changes
Comment thread staging/src/github.com/openshift/oc/pkg/cli/admin/release/mirror.go
abhinavdahiya
abhinavdahiya reviewed Jul 16, 2019
View reviewed changes
Comment thread staging/src/github.com/openshift/oc/pkg/cli/admin/release/mirror.go Outdated
abhinavdahiya
abhinavdahiya reviewed Jul 16, 2019
View reviewed changes
Comment thread staging/src/github.com/openshift/oc/pkg/cli/admin/release/mirror.go Outdated
@mtnbikenc
Add repo details for disconnected install/upgrade
43483d7 
When performing a release mirror, provide details of repos where images
have been mirrored from to be used for disconnected install or upgrade.
abhinavdahiya
abhinavdahiya reviewed Jul 16, 2019
View reviewed changes
Comment thread staging/src/github.com/openshift/oc/pkg/cli/admin/release/mirror.go Outdated
smarterclayton
smarterclayton reviewed Jul 17, 2019
View reviewed changes
Comment thread staging/src/github.com/openshift/oc/pkg/cli/admin/release/mirror.go
// Exmaple output:
//
// <descriptive installer usage text>
// imageContentSources:
Copy link
Copy Markdown
Contributor

@smarterclayton smarterclayton Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this be different between install and upgrade? I would expect us to print both sets, or to have a consistent set across both. I.e. how would I create an ICSP if the sources change?

smarterclayton
smarterclayton reviewed Jul 17, 2019
View reviewed changes
Comment thread staging/src/github.com/openshift/oc/pkg/cli/admin/release/mirror.go Outdated
smarterclayton
smarterclayton reviewed Jul 17, 2019
View reviewed changes
Comment thread staging/src/github.com/openshift/oc/pkg/cli/admin/release/mirror.go Outdated
smarterclayton
smarterclayton reviewed Jul 17, 2019
View reviewed changes
Comment thread staging/src/github.com/openshift/oc/pkg/cli/admin/release/mirror.go Outdated
smarterclayton
smarterclayton reviewed Jul 17, 2019
View reviewed changes
Comment thread staging/src/github.com/openshift/oc/pkg/cli/admin/release/mirror.go Outdated
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 17, 2019 •
edited
Loading

@mtnbikenc: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/unit 09b90f0 link /test unit
ci/prow/e2e-aws-serial 09b90f0 link /test e2e-aws-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 18, 2019

@mtnbikenc: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc mtnbikenc mentioned this pull request Jul 18, 2019
Merged
@mtnbikenc
Copy link
Copy Markdown
Member Author

mtnbikenc commented Jul 18, 2019

Resubmitted under openshift/oc#6
/close

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 18, 2019

@mtnbikenc: Closed this PR.

Details

In response to this:

Resubmitted under openshift/oc#6
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

3 more reviewers

@smarterclayton smarterclayton smarterclayton left review comments

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

@DanyC97 DanyC97 DanyC97 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mtnbikenc @openshift-ci-robot @abhinavdahiya @smarterclayton @DanyC97