Skip to content

Bug 1755991: bump runc for delegation fix#23868

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
rphillips:bump/runc_for_delegation_fix
Sep 30, 2019
Merged

Bug 1755991: bump runc for delegation fix#23868
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
rphillips:bump/runc_for_delegation_fix

Conversation

@rphillips
Copy link
Copy Markdown
Contributor

1st commit bumps dependencies with make update-deps. GRPC needed a bump.
2nd commit bumps runc with the fix.

ref [4.2]: #23860
4.3 BZ

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 26, 2019
@openshift-ci-robot
Copy link
Copy Markdown

@rphillips: This pull request references Bugzilla bug 1755991, which is invalid:

  • expected dependent Bugzilla bug 1698543 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1755991: bump runc for delegation fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 26, 2019
@mrunalp
Copy link
Copy Markdown
Member

mrunalp commented Sep 26, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2019
@wking
Copy link
Copy Markdown
Member

wking commented Sep 26, 2019

verify failure included:

unable to read file "/go/src/github.com/openshift/origin/hack/../vendor/k8s.io/kubernetes/hack/openapi-violation.list" for comparison: open /go/src/github.com/openshift/origin/hack/../vendor/k8s.io/kubernetes/hack/openapi-violation.list: no such file or directory

unit failure included:

FAIL: github.com/openshift/origin/vendor/k8s.io/apiserver/pkg/storage/cacher TestDispatchingBookmarkEventsWithConcurrentStop 1.04s
...
FAIL: github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/kubelet/oom TestBasic 0s

which isn't very helpful, although I didn't see more details about why those tests failed in a quick glance.

@rphillips rphillips force-pushed the bump/runc_for_delegation_fix branch from 423a878 to 86d74e8 Compare September 26, 2019 17:16
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 26, 2019
@rphillips
Copy link
Copy Markdown
Contributor Author

build issue

could not wait for build: the build src failed after 2m9s with reason PushImageToRegistryFailed: Failed to push the image to the registry.

@blomquisg
Copy link
Copy Markdown

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 27, 2019
@openshift-ci-robot
Copy link
Copy Markdown

@blomquisg: This pull request references Bugzilla bug 1755991, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 27, 2019
@rphillips rphillips force-pushed the bump/runc_for_delegation_fix branch from 86d74e8 to f7ef775 Compare September 27, 2019 19:17
@rphillips
Copy link
Copy Markdown
Contributor Author

rebased with the travis fix.

@nee1esh
Copy link
Copy Markdown

nee1esh commented Sep 30, 2019

@mrunalp can you lgtm this again?

@sjenning
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2019
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, rphillips, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2019
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0f0fc55 into openshift:master Sep 30, 2019
@openshift-ci-robot
Copy link
Copy Markdown

@rphillips: All pull requests linked via external trackers have merged. Bugzilla bug 1755991 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1755991: bump runc for delegation fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants