Project status should include some pod information

[smarterclayton]

Including the desired state annotations for rolling update

@fabianofranz review please

[fabianofranz]

switch

[smarterclayton]

Fixed

----- Original Message -----

• change := ""
• if changing, ok := deployutil.DeploymentDesiredReplicas(deploy); ok {

•   switch {
  

•   case changing < deploy.Spec.Replicas:
  

•       change = fmt.Sprintf(" reducing to %d", changing)
  

•   case changing > deploy.Spec.Replicas:
  

•       change = fmt.Sprintf(" growing to %d", changing)
  

•   }
  

• }
• return fmt.Sprintf(" - %s%s", s, change)
  +}

+func describeDeploymentPodSummary(deploy *kapi.ReplicationController,
showEmpty bool) string {

• actual, requested := deploy.Status.Replicas, deploy.Spec.Replicas
• if actual == requested {

•   if actual == 0 {
  

switch

---

Reply to this email directly or view it on GitHub:
https://github.com/openshift/origin/pull/2423/files#r30834784

[fabianofranz]

I found the login around the strings concatenation and punctuation a little hard to follow, but I guess it's still better than a Go template. So make sure you have tests for all scenarios (showEmpty, empty reason, etc). Otherwise LGTM.

[fabianofranz]

s/login/logic

[smarterclayton]

[merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/2050/) (Image: devenv-fedora_1594)

[openshift-bot]

Evaluated for origin up to 4f56890

[openshift-bot]

[Test]ing while waiting on the merge queue

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/2336/)