Skip to content

use apps/v1 instead of extensions/v1beta1 for deployment #24305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Dec 18, 2019
Merged

use apps/v1 instead of extensions/v1beta1 for deployment #24305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/extended/testdata/bindata.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/extended/testdata/service_catalog/ups-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ kind: Template
metadata:
name: ups-deployment-template
objects:
- apiVersion: extensions/v1beta1
- apiVersion: apps/v1
Copy link
Copy Markdown
Contributor

@tnozicka tnozicka Dec 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
doesn't this need updating the bindata? and why isn't verify screaming?

Copy link
Copy Markdown
Contributor Author

@p0lyn0mial p0lyn0mial Dec 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does, filling a BZ

Copy link
Copy Markdown
Contributor Author

@p0lyn0mial p0lyn0mial Dec 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://bugzilla.redhat.com/show_bug.cgi?id=1784324, thanks.

kind: Deployment
metadata:
labels:
Expand Down