Bug 1802262: Loosen help tests for oc rsh #24660

soltysh · 2020-03-09T11:51:17Z

4.3 backport of #24420

openshift-ci-robot · 2020-03-09T11:51:18Z

@soltysh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Loosen help tests for oc rsh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-09T11:51:55Z

@soltysh: This pull request references Bugzilla bug 1802262, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1794606 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1794606 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

Details

In response to this:

Bug 1802262: Loosen help tests for oc rsh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sallyom · 2020-03-09T14:06:21Z

/lgtm

openshift-bot · 2020-03-09T14:21:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-09T15:50:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-09T17:33:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-09T19:17:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-09T21:01:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-09T22:58:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-09T23:24:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-09T23:37:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-09T23:50:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-10T00:03:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-10T00:29:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-10T00:42:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-10T02:00:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-10T02:52:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-10T03:44:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-10T05:02:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-10T06:22:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-11T22:46:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-11T23:38:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-12T03:45:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-12T03:58:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-12T05:02:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-12T05:55:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-12T06:07:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-12T06:21:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-12T07:26:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-12T08:06:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-12T09:25:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-12T10:44:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sdodson · 2020-03-12T11:59:12Z

/hold
Please clear when the e2e-conformance-k8s failures are understood.

soltysh · 2020-03-16T14:15:45Z

Please clear when the e2e-conformance-k8s failures are understood.

They are weird since that particular tests git checkouts k8s directly and build kubectl. This PR is not touching this in any way and should not be affected. Lemme retry this test one more time.
/retest

sdodson · 2020-03-17T12:19:47Z

Dropping cherry-pick-approved from this PR so it doesn't merge outside of the merge window.

soltysh · 2020-03-17T14:20:36Z

/hold cancel

mfojtik · 2020-03-17T14:26:05Z

/lgtm

openshift-ci-robot · 2020-03-17T14:30:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, sallyom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/extended/OWNERS~~ [mfojtik,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

soltysh · 2020-03-17T15:01:32Z

/retest

openshift-bot · 2020-03-17T16:14:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

Loosen help tests for oc rsh

78b8d9c

openshift-ci-robot assigned sallyom Mar 9, 2020

openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2020

soltysh mentioned this pull request Mar 9, 2020

Bug 1802262: Use polymorphic helpers from exec, when reading a pod openshift/oc#294

Merged

soltysh changed the title ~~Loosen help tests for oc rsh~~ Bug 1802262: Loosen help tests for oc rsh Mar 9, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 9, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2020

openshift-ci-robot requested review from knobunc and mfojtik March 9, 2020 11:57

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2020

sdodson removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 17, 2020

Go 1.12 requires space-separated tags

b5baf8d

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2020

openshift-ci-robot assigned mfojtik Mar 17, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2020

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 18, 2020

openshift-merge-robot merged commit 7e49b95 into openshift:release-4.3 Mar 18, 2020

soltysh deleted the bug1802262 branch March 18, 2020 14:14

Bug 1802262: Loosen help tests for oc rsh #24660

Bug 1802262: Loosen help tests for oc rsh #24660

Uh oh!

Conversation

soltysh commented Mar 9, 2020

Uh oh!

openshift-ci-robot commented Mar 9, 2020

Uh oh!

openshift-ci-robot commented Mar 9, 2020

Uh oh!

sallyom commented Mar 9, 2020

Uh oh!

openshift-bot commented Mar 9, 2020

Uh oh!

openshift-bot commented Mar 9, 2020

Uh oh!

openshift-bot commented Mar 9, 2020

Uh oh!

openshift-bot commented Mar 9, 2020

Uh oh!

openshift-bot commented Mar 9, 2020

Uh oh!

openshift-bot commented Mar 9, 2020

Uh oh!

openshift-bot commented Mar 9, 2020

Uh oh!

openshift-bot commented Mar 9, 2020

Uh oh!

openshift-bot commented Mar 9, 2020

Uh oh!

openshift-bot commented Mar 10, 2020

Uh oh!

openshift-bot commented Mar 10, 2020

Uh oh!

openshift-bot commented Mar 10, 2020

Uh oh!

openshift-bot commented Mar 10, 2020

Uh oh!

openshift-bot commented Mar 10, 2020

Uh oh!

openshift-bot commented Mar 10, 2020

Uh oh!

openshift-bot commented Mar 10, 2020

Uh oh!

openshift-bot commented Mar 10, 2020

Uh oh!

openshift-bot commented Mar 11, 2020

Uh oh!

openshift-bot commented Mar 11, 2020

Uh oh!

openshift-bot commented Mar 12, 2020

Uh oh!

openshift-bot commented Mar 12, 2020

Uh oh!

openshift-bot commented Mar 12, 2020

Uh oh!

openshift-bot commented Mar 12, 2020

Uh oh!

openshift-bot commented Mar 12, 2020

Uh oh!

openshift-bot commented Mar 12, 2020

Uh oh!

openshift-bot commented Mar 12, 2020

Uh oh!

openshift-bot commented Mar 12, 2020

Uh oh!

openshift-bot commented Mar 12, 2020

Uh oh!

openshift-bot commented Mar 12, 2020

Uh oh!

sdodson commented Mar 12, 2020

Uh oh!

soltysh commented Mar 16, 2020

Uh oh!

sdodson commented Mar 17, 2020

Uh oh!

soltysh commented Mar 17, 2020

Uh oh!

mfojtik commented Mar 17, 2020

Uh oh!