Skip to content

Bug 1831042: Fix client-ca dynamic reload in apiserver#24942

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
tnozicka:fix-client-ca
May 5, 2020
Merged

Bug 1831042: Fix client-ca dynamic reload in apiserver#24942
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
tnozicka:fix-client-ca

Conversation

@tnozicka
Copy link
Copy Markdown
Contributor

@tnozicka tnozicka commented May 4, 2020

What this PR does / why we need it:
kube-apiserver fails to live reload changed client CA and front proxy CA and refuses clients signed by the new CA with 401 Unable to authenticate the request due to an error: x509: certificate signed by unknown authority

backport of kubernetes/kubernetes#90360

/cc @deads2k @sttts @soltysh

@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label May 4, 2020
@tnozicka tnozicka changed the title Bug : Fix client-ca dynamic reload in apiserver Bug 1831042: Fix client-ca dynamic reload in apiserver May 4, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 4, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 4, 2020

@tnozicka: This pull request references Bugzilla bug 1831042, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1831042: Fix client-ca dynamic reload in apiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnozicka tnozicka mentioned this pull request May 4, 2020
Merged
soltysh
soltysh approved these changes May 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold
for @marun bump PR

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 4, 2020
@tnozicka
Copy link
Copy Markdown
Contributor Author

tnozicka commented May 5, 2020

/retest

@tnozicka tnozicka mentioned this pull request May 5, 2020
Closed
@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented May 5, 2020

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2020
@tnozicka tnozicka mentioned this pull request May 5, 2020
Merged
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 83c486c into openshift:master May 5, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 5, 2020

@tnozicka: All pull requests linked via external trackers have merged: kubernetes/kubernetes#90360, openshift/origin#24942. Bugzilla bug 1831042 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1831042: Fix client-ca dynamic reload in apiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnozicka tnozicka deleted the fix-client-ca branch May 6, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@sttts sttts Awaiting requested review from sttts

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tnozicka @openshift-ci-robot @soltysh @openshift-bot @openshift-merge-robot