Bug 1731263: Balance preemption e2e nodes

[damemi]

These preemption e2es attempt to create filler "victim" pods that use 60% of a node's available resources, and assumes that with all nodes full, the low priority pod will get evicted.

However, if the nodes have very different usages (say one is at 500/1500 cpu and another is at 1000/1500), then the request of 60% of the low-priority-pod's-node's usage may not fit on one node, but will fit on another and the test fails.

This PR creates balanced pods in these e2es to ensure a level field for the preemption tests.

Upstream: kubernetes/kubernetes#90740

[openshift-ci-robot]

@damemi: This pull request references Bugzilla bug 1731263, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1731263: Balance preemption e2e nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[damemi]

So, re-enabled and with these fixes the tests fail with:

Unschedulable 0/6 nodes are available: 2 Insufficient memory, 3 Insufficient cpu, 3 node(s) didn't match node selector.}]
But they pass locally for me, because this is exactly the case I would expect preemption to happen it means that for some reason it must not be.

Something else I see is that the calculated usage for the balanced pods differs from the usage we calculate when creating the victim pods

[damemi]

/retest

[damemi]

/retest

[damemi]

/bugzilla refresh

[openshift-ci-robot]

@damemi: This pull request references Bugzilla bug 1731263, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[damemi]

/kind failing-test

[damemi]

/retest

[soltysh]

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[soltysh]

/hold
for k8s bump, feel to drop when that lands.

[damemi]

#24936 has merged the 1.18.2 bump
/hold cancel

[openshift-ci-robot]

@damemi: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:

• openshift/origin#23050 is closed
  Bugzilla bug 1731263 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1731263: Balance preemption e2e nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.