[release-4.5] Bug 1845078: All NetworkPolicy tests currently being skipped on openshift-sdn#25074

Merged

openshift-merge-robot merged 1 commit intoopenshift:release-4.5from

openshift-cherrypick-robot:cherry-pick-25052-to-release-4.5

Jun 23, 2020

openshift-cherrypick-robot commented Jun 8, 2020

This is an automated cherry-pick of #25052

/assign danwinship


          test: fix network-plugin-related skips

d155be2

The old code allowed annotating tests as both
"[Skipped:Network/OpenShiftSDN]" ("Skip on OpenShiftSDN") and
"[Skipped:Network/OpenShiftSDN/Multitenant]" ("Skip on OpenShiftSDN in
Multitenant mode"). But the current code lost that distinction and
ended up skipping the "only skip in Multitenant mode" tests even in
NetworkPolicy mode (meaning we were always skipping the NetworkPolicy
tests on openshift-sdn).

openshift-cherrypick-robot mentioned this pull request

Bug 1842650: All NetworkPolicy tests currently being skipped on openshift-sdn #25052

Merged

openshift-ci-robot assigned danwinship

openshift-ci-robot commented Jun 8, 2020

@openshift-cherrypick-robot: Bugzilla bug 1842650 has been cloned as Bugzilla bug 1845078. Retitling PR to link against new bug.
/retitle [release-4.5] Bug 1845078: All NetworkPolicy tests currently being skipped on openshift-sdn

Details

In response to this:

[release-4.5] Bug 1842650: All NetworkPolicy tests currently being skipped on openshift-sdn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot changed the title ~~[release-4.5] Bug 1842650: All NetworkPolicy tests currently being skipped on openshift-sdn~~ [release-4.5] Bug 1845078: All NetworkPolicy tests currently being skipped on openshift-sdn

openshift-ci-robot requested review from adambkaplan and pweil-

June 8, 2020 12:28

openshift-ci-robot added the bugzilla/severity-high label

openshift-ci-robot commented Jun 8, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1845078, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1842650 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Bugzilla bug 1842650 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
bug has dependents

Details

In response to this:

[release-4.5] Bug 1845078: All NetworkPolicy tests currently being skipped on openshift-sdn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/valid-bug label

Contributor

danwinship commented Jun 8, 2020

/assign @knobunc

openshift-ci-robot assigned knobunc

Contributor

knobunc commented Jun 8, 2020

/lgtm
/approve

openshift-ci-robot added the lgtm label

openshift-ci-robot commented Jun 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~cmd/OWNERS~~ [knobunc]
~~test/extended/OWNERS~~ [knobunc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the approved label

knobunc added the staff-eng-approved label

Contributor

knobunc commented Jun 8, 2020

/retest

Contributor

openshift-bot commented Jun 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

11 similar comments

Contributor

openshift-bot commented Jun 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

17 similar comments

Contributor

openshift-bot commented Jun 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

sdodson added the cherry-pick-approved label

Contributor

openshift-bot commented Jun 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment

Contributor

openshift-bot commented Jun 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

sdodson added cherry-pick-approved and removed cherry-pick-approved labels

Contributor

openshift-bot commented Jun 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Member

sdodson commented Jun 23, 2020

/override ci/prow/e2e-aws-disruptive

openshift-ci-robot commented Jun 23, 2020

@sdodson: Cannot update PR status for context ci/prow/e2e-aws-disruptive

Details

In response to this:

/override ci/prow/e2e-aws-disruptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot merged commit 706c6d8 into openshift:release-4.5

openshift-ci-robot commented Jun 23, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/origin#25074. Bugzilla bug 1845078 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.5] Bug 1845078: All NetworkPolicy tests currently being skipped on openshift-sdn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

danwinship commented Jun 23, 2020

just when you thought it was safe to go back in the water...
/cherry-pick release-4.4

Author

openshift-cherrypick-robot commented Jun 23, 2020

@danwinship: #25074 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	cmd/openshift-tests/provider.go
M	test/extended/util/cloud/cloud.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/util/cloud/cloud.go
CONFLICT (content): Merge conflict in test/extended/util/cloud/cloud.go
Auto-merging cmd/openshift-tests/provider.go
Patch failed at 0001 test: fix network-plugin-related skips

Details

In response to this:

just when you thought it was safe to go back in the water...
/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved bugzilla/severity-high bugzilla/valid-bug cherry-pick-approved lgtm staff-eng-approved