Skip to content

[release-4.5] Bug 1845291: Measure container restarts over an interval instead of absolute#25152

Merged
smarterclayton merged 1 commit intoopenshift:release-4.5from
openshift-cherrypick-robot:cherry-pick-25115-to-release-4.5
Jun 19, 2020
Merged

[release-4.5] Bug 1845291: Measure container restarts over an interval instead of absolute#25152
smarterclayton merged 1 commit intoopenshift:release-4.5from
openshift-cherrypick-robot:cherry-pick-25115-to-release-4.5

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jun 18, 2020

This is an automated cherry-pick of #25115

/assign hexfusion

@smarterclayton
Measure container restarts over an interval instead of absolute
74ff8b5 
We run these tests after disruptive events where restarts are
necessary. Instead of looking at absolute restart count, capture
the number of initial restarts and then compare subsequent runs
to ensure the count is smaller. We double the time interval and
halve the number of failing restarts in order to ensure we capture
slow restart failures (full backoff is 5m, but we can catch slow
but not limited backoff).
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 18, 2020
Merged
@hexfusion
Copy link
Copy Markdown
Contributor

hexfusion commented Jun 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@hexfusion
Copy link
Copy Markdown
Contributor

hexfusion commented Jun 18, 2020

/test e2e-conformance-k8s

@hexfusion
Copy link
Copy Markdown
Contributor

hexfusion commented Jun 18, 2020

/retest

@hexfusion
Copy link
Copy Markdown
Contributor

hexfusion commented Jun 18, 2020

/refresh

@hexfusion
Copy link
Copy Markdown
Contributor

hexfusion commented Jun 18, 2020

/retest

@mfojtik mfojtik added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jun 19, 2020
@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented Jun 19, 2020

/approve
/retest

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, mfojtik, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2020
@hexfusion
Copy link
Copy Markdown
Contributor

hexfusion commented Jun 19, 2020

/retest

@hexfusion hexfusion mentioned this pull request Jun 19, 2020
Merged
@hexfusion
Copy link
Copy Markdown
Contributor

hexfusion commented Jun 19, 2020

This needs an override on e2e-aws-disruptive as this patch helps fix the test.

@smarterclayton smarterclayton changed the title [release-4.5] Measure container restarts over an interval instead of absolute [release-4.5] Bug 1845291: Measure container restarts over an interval instead of absolute Jun 19, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 19, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1845291, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1797244 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1797244 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents
Details

In response to this:

[release-4.5] Bug 1845291: Measure container restarts over an interval instead of absolute

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 19, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 19, 2020

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-builds 74ff8b5 link /test e2e-gcp-builds
ci/prow/e2e-azure 74ff8b5 link /test e2e-azure
ci/prow/e2e-aws-disruptive 74ff8b5 link /test e2e-aws-disruptive
ci/prow/e2e-vsphere 74ff8b5 link /test e2e-vsphere

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Jun 19, 2020

Force merging because the test itself passed and we need to unblock the disurptive suite

@smarterclayton smarterclayton merged commit 1b98519 into openshift:release-4.5 Jun 19, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 19, 2020

@openshift-cherrypick-robot: Some pull requests linked via external trackers have merged: openshift/origin#25152. The following pull requests linked via external trackers have not merged:

Details

In response to this:

[release-4.5] Bug 1845291: Measure container restarts over an interval instead of absolute

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@hexfusion hexfusion

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @hexfusion @mfojtik @openshift-ci-robot @smarterclayton