Skip to content

Bug 1842653: [4.4] All NetworkPolicy tests currently being skipped on openshift-sdn#25197

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.4from
danwinship:network-skips-4.4
Sep 26, 2020
Merged

Bug 1842653: [4.4] All NetworkPolicy tests currently being skipped on openshift-sdn#25197
openshift-merge-robot merged 1 commit intoopenshift:release-4.4from
danwinship:network-skips-4.4

Conversation

@danwinship
Copy link
Copy Markdown
Contributor

@danwinship danwinship commented Jun 23, 2020

Backport of #25052 to release-4.4
/assign @knobunc

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jun 23, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 23, 2020

@danwinship: This pull request references Bugzilla bug 1842653, which is invalid:

  • expected dependent Bugzilla bug 1842650 to target a release in 4.5.0, 4.5.z, but it targets "4.6.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1842653: [4.4] All NetworkPolicy tests currently being skipped on openshift-sdn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 23, 2020
@danwinship
Copy link
Copy Markdown
Contributor Author

danwinship commented Jun 23, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 23, 2020

@danwinship: This pull request references Bugzilla bug 1842653, which is invalid:

  • expected dependent Bugzilla bug 1845078 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship
Copy link
Copy Markdown
Contributor Author

danwinship commented Jun 29, 2020

/bugzilla refresh
/retest

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 29, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 29, 2020

@danwinship: This pull request references Bugzilla bug 1842653, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1845078 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1845078 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents
Details

In response to this:

/bugzilla refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship
Copy link
Copy Markdown
Contributor Author

danwinship commented Jul 6, 2020

/retest

4 similar comments
@danwinship
Copy link
Copy Markdown
Contributor Author

danwinship commented Jul 8, 2020

/retest

@danwinship
Copy link
Copy Markdown
Contributor Author

danwinship commented Jul 13, 2020

/retest

@danwinship
Copy link
Copy Markdown
Contributor Author

danwinship commented Jul 19, 2020

/retest

@danwinship
Copy link
Copy Markdown
Contributor Author

danwinship commented Aug 3, 2020

/retest

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 3, 2020

@danwinship: The /test command needs one or more targets.
The following commands are available to trigger jobs:

  • /test artifacts
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-image-registry
  • /test e2e-aws-jenkins
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-serial
  • /test e2e-azure
  • /test e2e-cmd
  • /test e2e-conformance-k8s
  • /test e2e-gcp
  • /test e2e-gcp-builds
  • /test e2e-gcp-image-ecosystem
  • /test e2e-gcp-upgrade
  • /test e2e-vsphere
  • /test images
  • /test unit
  • /test verify

Use /test all to run the following jobs:

  • pull-ci-openshift-origin-release-4.4-e2e-aws-csi
  • pull-ci-openshift-origin-release-4.4-e2e-aws-fips
  • pull-ci-openshift-origin-release-4.4-e2e-aws-serial
  • pull-ci-openshift-origin-release-4.4-e2e-cmd
  • pull-ci-openshift-origin-release-4.4-e2e-gcp
  • pull-ci-openshift-origin-release-4.4-e2e-gcp-builds
  • pull-ci-openshift-origin-release-4.4-e2e-gcp-upgrade
  • pull-ci-openshift-origin-release-4.4-images
  • pull-ci-openshift-origin-release-4.4-unit
  • pull-ci-openshift-origin-release-4.4-verify
Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship
Copy link
Copy Markdown
Contributor Author

danwinship commented Aug 10, 2020

/retest

@knobunc
Copy link
Copy Markdown
Contributor

knobunc commented Aug 10, 2020

/approve

@knobunc
Copy link
Copy Markdown
Contributor

knobunc commented Aug 10, 2020

/lgtm

@knobunc
Copy link
Copy Markdown
Contributor

knobunc commented Aug 10, 2020

/retest

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Aug 10, 2020
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@danwinship
Copy link
Copy Markdown
Contributor Author

danwinship commented Sep 19, 2020

/lgtm cancel
I was assuming that CI was just broken but it appears that other 4.4 PRs have merged

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2020
@danwinship
test: fix network-plugin-related skips
29d6c73 
The old code allowed doing both "[Skipped:Network/OpenShiftSDN]"
("Skip on OpenShiftSDN") and
"[Skipped:Network/OpenShiftSDN/Multitenant]" ("Skip on OpenShiftSDN in
Multitenant mode"), and the test annotations made use of this. But the
current code lost that distinction and ended up skipping the "only
skip in Multitenant mode" tests even in NetworkPolicy mode (meaning we
were always skipping the NetworkPolicy tests on openshift-sdn).
@markmc markmc removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 21, 2020
@danwinship
Copy link
Copy Markdown
Contributor Author

danwinship commented Sep 21, 2020

/retest

@knobunc
Copy link
Copy Markdown
Contributor

knobunc commented Sep 22, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmc markmc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 25, 2020
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 45f8ddb into openshift:release-4.4 Sep 26, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 26, 2020

@danwinship: All pull requests linked via external trackers have merged:

Bugzilla bug 1842653 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1842653: [4.4] All NetworkPolicy tests currently being skipped on openshift-sdn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@knobunc knobunc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@danwinship @openshift-ci-robot @knobunc @openshift-bot @jwforres @derekwaynecarr @eparis @markmc @openshift-merge-robot