Bug 1850719: Measure container restarts over an interval instead of absolute by hexfusion · Pull Request #25202 · openshift/origin

hexfusion · 2020-06-24T19:26:09Z

Manual cherry-pick of #25115 into 4.4

openshift-ci-robot · 2020-06-24T19:26:10Z

@hexfusion: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Measure container restarts over an interval instead of absolute

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-06-24T19:42:03Z

@hexfusion: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

1850719: Measure container restarts over an interval instead of absolute

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hexfusion · 2020-06-25T01:12:36Z

/retest

openshift-ci-robot · 2020-06-25T01:18:07Z

@hexfusion: This pull request references Bugzilla bug 1850719, which is invalid:

expected dependent Bugzilla bug 1797244 to target a release in 4.5.0, 4.5.z, but it targets "4.6.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1850719: Measure container restarts over an interval instead of absolute

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

We run these tests after disruptive events where restarts are necessary. Instead of looking at absolute restart count, capture the number of initial restarts and then compare subsequent runs to ensure the count is smaller. We double the time interval and halve the number of failing restarts in order to ensure we capture slow restart failures (full backoff is 5m, but we can catch slow but not limited backoff).

hexfusion · 2020-06-26T00:40:33Z

/retest

hexfusion · 2020-06-26T18:30:42Z

/retest

hexfusion · 2020-06-27T11:38:28Z

/retest

hexfusion · 2020-06-27T17:56:38Z

cc @smarterclayton @bparees

unblocking disruptive test for 4.4

openshift-ci-robot · 2020-06-27T17:58:27Z

@hexfusion: This pull request references Bugzilla bug 1850719, which is invalid:

expected dependent Bugzilla bug 1797244 to target a release in 4.5.0, 4.5.z, but it targets "4.6.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1850719: Measure container restarts over an interval instead of absolute

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2020-06-29T01:39:09Z

i fixed up the BZ deps but i think this will still be stuck on the 4.5 BZ verification:

/bugzilla refresh

openshift-ci-robot · 2020-06-29T01:39:11Z

@bparees: This pull request references Bugzilla bug 1850719, which is invalid:

expected dependent Bugzilla bug 1845291 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

i fixed up the BZ deps but i think this will still be stuck on the 4.5 BZ verification:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2020-06-29T01:40:24Z

@hexfusion if this test is failing in 4.4, the severity should be higher. if it's not failing in 4.4, then you're probably going to get pushback from the patch manager about the need to backport this.

/lgtm
/approve

openshift-ci-robot · 2020-06-29T01:43:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/extended/OWNERS~~ [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-06-30T01:00:52Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-30T01:00:58Z

@openshift-bot: This pull request references Bugzilla bug 1850719, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.z) matches configured target release for branch (4.4.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1845291 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1845291 targets the "4.5.z" release, which is one of the valid target releases: 4.5.0, 4.5.z
bug has dependents

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-07-03T14:06:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-03T14:58:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-03T19:44:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-03T19:57:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-07-03T21:52:59Z

@hexfusion: All pull requests linked via external trackers have merged: openshift/origin#25202. Bugzilla bug 1850719 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1850719: Measure container restarts over an interval instead of absolute

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from bparees and knobunc June 24, 2020 19:26

hexfusion changed the title ~~Measure container restarts over an interval instead of absolute~~ 1850719: Measure container restarts over an interval instead of absolute Jun 24, 2020

hexfusion changed the title ~~1850719: Measure container restarts over an interval instead of absolute~~ Bug 1850719: Measure container restarts over an interval instead of absolute Jun 25, 2020

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 25, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 25, 2020

hexfusion force-pushed the cp-25115 branch from 17e7709 to 0bbe9fc Compare June 25, 2020 14:18

openshift-ci-robot assigned bparees Jun 29, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 30, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 30, 2020

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 3, 2020

openshift-merge-robot merged commit a1af596 into openshift:release-4.4 Jul 3, 2020

Conversation

hexfusion commented Jun 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 24, 2020

Uh oh!

openshift-ci-robot commented Jun 24, 2020

Uh oh!

hexfusion commented Jun 25, 2020

Uh oh!

openshift-ci-robot commented Jun 25, 2020

Uh oh!

hexfusion commented Jun 26, 2020

Uh oh!

hexfusion commented Jun 26, 2020

Uh oh!

hexfusion commented Jun 27, 2020

Uh oh!

hexfusion commented Jun 27, 2020

Uh oh!

openshift-ci-robot commented Jun 27, 2020

Uh oh!

bparees commented Jun 29, 2020

Uh oh!

openshift-ci-robot commented Jun 29, 2020

Uh oh!

bparees commented Jun 29, 2020

Uh oh!

openshift-ci-robot commented Jun 29, 2020

Uh oh!

openshift-bot commented Jun 30, 2020

Uh oh!

openshift-ci-robot commented Jun 30, 2020

Uh oh!

openshift-bot commented Jul 3, 2020

Uh oh!

openshift-bot commented Jul 3, 2020

Uh oh!

openshift-bot commented Jul 3, 2020

Uh oh!

openshift-bot commented Jul 3, 2020

Uh oh!

openshift-ci-robot commented Jul 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

hexfusion commented Jun 24, 2020 •

edited

Loading