Skip to content

bug 1861189: UPSTREAM: <drop>: make pdb tests pass reliably #25335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deads2k merged 1 commit into from
Jul 29, 2020
Merged

bug 1861189: UPSTREAM: <drop>: make pdb tests pass reliably #25335

deads2k merged 1 commit into from
Jul 29, 2020

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Jul 28, 2020

pdbs were fixed to be more tolerant of certain classes of delete. This means old tests and new cluster break because the delete isn't constrained. We need kubernetes/kubernetes#92991 . I pulled the entire file in to be sure.

This will go away once we revendor, but the level in o/k is right. If pdb tests pass, we should green button this.

@openshift-ci-robot openshift-ci-robot added vendor-update Touching vendor dir or related files approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2020
@bparees
Copy link
Contributor

bparees commented Jul 28, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k deads2k changed the title UPSTREAM: <drop>: make pdb tests pass reliably bug https://bugzilla.redhat.com/show_bug.cgi?id=1861189: UPSTREAM: <drop>: make pdb tests pass reliably Jul 28, 2020
@deads2k deads2k changed the title bug https://bugzilla.redhat.com/show_bug.cgi?id=1861189: UPSTREAM: <drop>: make pdb tests pass reliably bug 1861189: UPSTREAM: <drop>: make pdb tests pass reliably Jul 28, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 28, 2020

@deads2k: This pull request references Bugzilla bug 1861189, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

bug 1861189: UPSTREAM: : make pdb tests pass reliably

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 28, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2020
@marun
Copy link
Contributor

marun commented Jul 28, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2020
@marun
Copy link
Contributor

marun commented Jul 28, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@marun
Copy link
Contributor

marun commented Jul 28, 2020

/hold

There are more than one test failures blocking the merging of this change. Please prioritize merging #25314 instead, which fixes and skips a number of issues introduced by the 1.19 rebase. This PR will then need to unskip.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 28, 2020

@deads2k: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify-deps dfae334 link /test verify-deps
ci/prow/e2e-gcp dfae334 link /test e2e-gcp
ci/prow/e2e-aws-serial dfae334 link /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k mentioned this pull request Jul 29, 2020
Merged
@deads2k
Copy link
Contributor Author

deads2k commented Jul 29, 2020

this fixes the must-gather problem. TRT is prioritizing unblocking the payload promotion and this resolves one of two issues. #25335 / #25336 resolves the other. We will merge these

@deads2k deads2k merged commit 1f64bb0 into openshift:master Jul 29, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 29, 2020

@deads2k: All pull requests linked via external trackers have merged: . Bugzilla bug 1861189 has been moved to the MODIFIED state.

Details

In response to this:

bug 1861189: UPSTREAM: : make pdb tests pass reliably

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Contributor

sttts commented Jul 30, 2020

This broke origin merges 🎉 Do not button merge ignoring verify scripts 😞

@bparees
Copy link
Contributor

bparees commented Jul 30, 2020

This broke origin merges tada Do not button merge ignoring verify scripts

this was a deliberate choice as it unblocked more than it broke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@bparees bparees

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@deads2k @bparees @openshift-ci-robot @openshift-bot @marun @sttts