Skip to content

Bug 1874061: Add diff to tests, since e2e-cmd relies on it#25455

Closed
soltysh wants to merge 1 commit intoopenshift:masterfrom
soltysh:find
Closed

Bug 1874061: Add diff to tests, since e2e-cmd relies on it#25455
soltysh wants to merge 1 commit intoopenshift:masterfrom
soltysh:find

Conversation

@soltysh
Copy link
Copy Markdown
Contributor

@soltysh soltysh commented Aug 31, 2020

/assign @tnozicka

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 31, 2020
@openshift-ci-robot
Copy link
Copy Markdown

@soltysh: This pull request references Bugzilla bug 1874061, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1874061: Add diff to tests, since e2e-cmd relies on it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2020
Copy link
Copy Markdown
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
This is only temporary to unblock e2e-cmd (broken by switch to ubi8) while we work on migrating it to e2e suite

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Copy Markdown
Contributor Author

soltysh commented Aug 31, 2020

/test e2e-cmd

@openshift-ci-robot
Copy link
Copy Markdown

@soltysh: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-cmd 49d1086 link /test e2e-cmd
ci/prow/e2e-aws-fips 49d1086 link /test e2e-aws-fips
ci/prow/e2e-aws-csi 49d1086 link /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yselkowitz
Copy link
Copy Markdown
Contributor

openshift/images#35 should render this unnecessary.

@soltysh
Copy link
Copy Markdown
Contributor Author

soltysh commented Aug 31, 2020

Closing in favor of openshift/images#35

@soltysh soltysh closed this Aug 31, 2020
@openshift-ci-robot
Copy link
Copy Markdown

@soltysh: This pull request references Bugzilla bug 1874061. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1874061: Add diff to tests, since e2e-cmd relies on it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh soltysh deleted the find branch August 31, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants