Skip to content

Bug 1872375: Add system:authenticated exception for HelmChartRepository CRs used by console #25485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 10, 2020
Merged

Bug 1872375: Add system:authenticated exception for HelmChartRepository CRs used by console #25485

openshift-merge-robot merged 1 commit into from
Sep 10, 2020

Conversation

@pedjak
Copy link
Contributor

@pedjak pedjak commented Sep 8, 2020 •
edited
Loading

HelmChartRepository instances keep Helm chart repository configuration.
By default users are able to browse charts from all configured repositories through console

To unblock openshift/console-operator#458

cc @jhadvig @spadgett

@pedjak
Add system:authenticated exception for HelmChartRepository CRs used b…
9f1c81c 
…y console

HelmChartRepository instances keep Helm chart repository configuration.
By default users are able to browse charts from all configured repositories through console
pedjak
pedjak commented Sep 8, 2020
View reviewed changes
test/extended/authorization/rbac/groups_default_rules.go

// HelmChartRepository instances keep Helm chart repository configuration
// By default users are able to browse charts from all configured repositories through console UI
rbacv1helpers.NewRule("get", "list").Groups("helm.openshift.io").Resources("helmchartrepositories").RuleOrDie(),
Copy link
Contributor Author

@pedjak pedjak Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to refer group name via helm.GroupName, #25468 needs to get in first.

@pedjak pedjak mentioned this pull request Sep 8, 2020
Merged
jhadvig
jhadvig approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2020
@pedjak pedjak changed the title Add system:authenticated exception for HelmChartRepository CRs used by console Bug 1872375: Add system:authenticated exception for HelmChartRepository CRs used by console Sep 10, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 10, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 10, 2020

@pedjak: This pull request references Bugzilla bug 1872375, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1872375: Add system:authenticated exception for HelmChartRepository CRs used by console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pedjak
Copy link
Contributor Author

pedjak commented Sep 10, 2020

/assign @ironcladlou

@spadgett
Copy link
Member

spadgett commented Sep 10, 2020

/unassign @ironcladlou
/assign @bparees

@bparees
Copy link
Contributor

bparees commented Sep 10, 2020

/approve

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jhadvig, pedjak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4643df5 into openshift:master Sep 10, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 10, 2020

@pedjak: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1872375 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1872375: Add system:authenticated exception for HelmChartRepository CRs used by console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericavonb ericavonb Awaiting requested review from ericavonb

@sallyom sallyom Awaiting requested review from sallyom

1 more reviewer

@jhadvig jhadvig jhadvig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jhadvig jhadvig

@bparees bparees

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@pedjak @openshift-ci-robot @spadgett @bparees @openshift-bot @jhadvig @ironcladlou @openshift-merge-robot