Skip to content

Conversation

@ironcladlou
Copy link
Contributor

@ironcladlou ironcladlou commented Sep 28, 2020

Somehow the committed test annotations are out of sync. This patch
regenerates them correctly.

$ docker run --rm -it golang:1.15
root@4ed2098ed00a:/go# git clone https://github.com/openshift/origin.git
Cloning into 'origin'...
remote: Enumerating objects: 5791, done.
remote: Counting objects: 100% (5791/5791), done.
remote: Compressing objects: 100% (4027/4027), done.
remote: Total 655804 (delta 3417), reused 1769 (delta 1764), pack-reused 650013
Receiving objects: 100% (655804/655804), 1.09 GiB | 14.74 MiB/s, done.
Resolving deltas: 100% (404416/404416), done.
Checking out files: 100% (14558/14558), done.
root@4ed2098ed00a:/go# cd origin
root@4ed2098ed00a:/go/origin# hack/update-generated.sh
hack/update-generated.sh took 357 seconds
root@4ed2098ed00a:/go/origin# git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   test/extended/util/annotate/generated/zz_generated.annotations.go

no changes added to commit (use "git add" and/or "git commit -a")

Somehow the committed test annotations are out of sync. This patch
regenerates them correctly.
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2020
@ironcladlou
Copy link
Contributor Author

@marun @smarterclayton

@marun is suspicious of the generator itself, hope this data point is useful. I can close if this isn't the problem.

@openshift-ci-robot
Copy link

@ironcladlou: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify ad413eb link /test verify
ci/prow/e2e-gcp-upgrade ad413eb link /test e2e-gcp-upgrade
ci/prow/e2e-cmd ad413eb link /test e2e-cmd

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ironcladlou
Copy link
Contributor Author

Yuck, GOPATH has been dead and buried for a long time. Thanks for digging into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants