Skip to content

Bug 1921088: don't wait for PV removal in volumes.sh #25827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smarterclayton merged 2 commits into from
Jan 28, 2021
Merged

Bug 1921088: don't wait for PV removal in volumes.sh #25827

smarterclayton merged 2 commits into from
Jan 28, 2021

Conversation

@soltysh
Copy link
Contributor

@soltysh soltysh commented Jan 26, 2021 •
edited
Loading

We were unnecessarily waiting for PV removal in volumes.sh test which caused this particular test to stuck for removal of a PV which it didn't create in the first place.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2021
@soltysh soltysh force-pushed the volumes_debug branch 2 times, most recently from af30b78 to 21a82ca Compare January 27, 2021 12:38
@soltysh soltysh changed the title WIP: Debug volumes.sh Bug 1921088: don't wait for PV removal in volumes.sh Jan 27, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 27, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 27, 2021

@soltysh: This pull request references Bugzilla bug 1921088, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1921088: don't wait for PV removal in volumes.sh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 27, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 27, 2021

@soltysh: This pull request references Bugzilla bug 1921088, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1921088: don't wait for PV removal in volumes.sh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Contributor Author

soltysh commented Jan 27, 2021

/cherry-pick release-4.6

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 27, 2021

@soltysh: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smarterclayton
Copy link
Contributor

smarterclayton commented Jan 27, 2021

/refresh

@smarterclayton
Copy link
Contributor

smarterclayton commented Jan 27, 2021

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 27, 2021

@soltysh: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp 83546db link /test e2e-gcp
ci/prow/e2e-agnostic-cmd 83546db link /test e2e-agnostic-cmd
ci/prow/e2e-gcp-upgrade 83546db link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Contributor Author

soltysh commented Jan 27, 2021

Infra limits
/retest

@soltysh soltysh mentioned this pull request Jan 27, 2021
Merged
@soltysh
Copy link
Contributor Author

soltysh commented Jan 27, 2021

IAM limits was reported to CI team, should be fixed now
/test e2e-agnostic-cmd

@smarterclayton
Copy link
Contributor

smarterclayton commented Jan 28, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton
Copy link
Contributor

smarterclayton commented Jan 28, 2021

Overriding to clear the queue.

@smarterclayton smarterclayton merged commit 3d03056 into openshift:master Jan 28, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 28, 2021

@soltysh: All pull requests linked via external trackers have merged:

Bugzilla bug 1921088 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1921088: don't wait for PV removal in volumes.sh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 28, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 28, 2021

@soltysh: new pull request created: #25831

Details

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh soltysh deleted the volumes_debug branch January 28, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

@smarterclayton smarterclayton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@soltysh @openshift-ci-robot @openshift-cherrypick-robot @smarterclayton