Skip to content

test: External image test was silently failing#25958

Merged
smarterclayton merged 2 commits intoopenshift:masterfrom
smarterclayton:panic_missing
Mar 17, 2021
Merged

test: External image test was silently failing#25958
smarterclayton merged 2 commits intoopenshift:masterfrom
smarterclayton:panic_missing

Conversation

@smarterclayton
Copy link
Copy Markdown
Contributor

@smarterclayton smarterclayton commented Mar 11, 2021 •
edited
Loading

As a result we were not catching images that had not been mirrored.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2021
@smarterclayton
test: Correctly detect non-mirrored images
a188ea8 
Excluding e2e-* namespaces was subtly broken and as a result the
test was not running.
@smarterclayton smarterclayton changed the title DO NOT MERGE: Why is this not running? test: External image test was silently failing Mar 16, 2021
@smarterclayton
test: Fix regressions in missing images
f02938d 
The test was disabled, which caused code to regress. Add the code back
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2021
@smarterclayton
Copy link
Copy Markdown
Contributor Author

smarterclayton commented Mar 17, 2021

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 17, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 17, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 17, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 17, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 17, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 17, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link
Copy Markdown
Contributor Author

smarterclayton commented Mar 17, 2021

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 17, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 17, 2021

@smarterclayton: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-upgrade f02938d link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 17, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link
Copy Markdown
Contributor Author

smarterclayton commented Mar 17, 2021

Merging to prevent regressions (upgrade passed with this check)

@smarterclayton smarterclayton merged commit 5030a56 into openshift:master Mar 17, 2021
@gabemontero gabemontero mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwforres jwforres Awaiting requested review from jwforres

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smarterclayton @openshift-ci-robot @openshift-bot