Skip to content

WIP - [release-4.5] Bug 1939550: Update tests to use Ruby 2.6 #25991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adambkaplan wants to merge 1 commit into from
Closed

WIP - [release-4.5] Bug 1939550: Update tests to use Ruby 2.6 #25991

adambkaplan wants to merge 1 commit into from

Conversation

@adambkaplan
Copy link
Contributor

@adambkaplan adambkaplan commented Mar 19, 2021 •
edited
Loading

Update orign tests to use Ruby 2.6 instead of Ruby 2.5.
github.com/openshift/ruby-hello-world was updated to use Ruby 2.7,
which breaks many tests that were based on Ruby 2.5.

Tests which relied on the Dockerfile in ruby-hello-world are disabled
because it explicitly uses the ruby 2.7 imagestream, which is not
available on OCP 4.5.

Other changes:

  • Fix check on build args warning
  • Test that checks if we infer the origin imagestream tag was switched
    from a centos image to the ruby imagestream.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Mar 19, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2021

@adambkaplan: This pull request references Bugzilla bug 1939550, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1939549 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1939549 targets the "4.6.z" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

Requesting review from QA contact:
/cc @xiuwang

Details

In response to this:

[release-4.5] Bug 1939550: Update tests to use Ruby 2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 19, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2021
@gabemontero
Copy link
Contributor

gabemontero commented Mar 19, 2021

preliminary

/lgtm

can readd of something 4.5 specific crops up in the e2e results

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

18 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 20, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 22, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 22, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 22, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 22, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@adambkaplan
Copy link
Contributor Author

adambkaplan commented Mar 22, 2021

/hold

Is ruby 2.7 not in 4.5?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2021
@xiuwang
Copy link
Contributor

xiuwang commented Mar 23, 2021

Is ruby 2.7 not in 4.5?
Yes, on 4.5, latest tag is pointing to ruby:2.6 istag

@jwforres jwforres added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 24, 2021
@markmc markmc added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Apr 1, 2021
@markmc markmc mentioned this pull request Apr 1, 2021
Closed
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 13, 2021

New changes are detected. LGTM label has been removed.

@gabemontero
Copy link
Contributor

gabemontero commented Apr 13, 2021 •
edited
Loading

update the PR title and and description @adambkaplan to reference 2.6 instead of 2.7 and I'll apply the lgtm

@adambkaplan adambkaplan changed the title [release-4.5] Bug 1939550: Update tests to use Ruby 2.7 WIP - [release-4.5] Bug 1939550: Update tests to use Ruby 2.7 Apr 15, 2021
@adambkaplan adambkaplan changed the title WIP - [release-4.5] Bug 1939550: Update tests to use Ruby 2.7 WIP - [release-4.5] Bug 1939550: Update tests to use Ruby 2.6 Apr 15, 2021
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 16, 2021

@adambkaplan: This pull request references Bugzilla bug 1939550, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1939549 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1939549 targets the "4.6.z" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

Requesting review from QA contact:
/cc @xiuwang

Details

In response to this:

WIP - [release-4.5] Bug 1939550: Update tests to use Ruby 2.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 16, 2021

@adambkaplan: This pull request references Bugzilla bug 1939550, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1939549 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1939549 targets the "4.6.z" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

Requesting review from QA contact:
/cc @xiuwang

Details

In response to this:

WIP - [release-4.5] Bug 1939550: Update tests to use Ruby 2.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot @adambkaplan
[release-4.5] Bug 1939550: Update tests to use Ruby 2.6
b475646 
Update orign tests to use Ruby 2.6 instead of Ruby 2.5.
github.com/openshift/ruby-hello-world was updated to use Ruby 2.7,
which breaks many tests that were based on Ruby 2.5.

Tests which relied on the Dockerfile in ruby-hello-world are disabled
because it explicitly uses the ruby 2.7 imagestream, which is not
available on OCP 4.5.

Other changes:

- Fix check on build args warning
- Test that checks if we infer the origin imagestream tag was switched
from a centos image to the ruby imagestream.
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 16, 2021

@adambkaplan: This pull request references Bugzilla bug 1939550, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1939549 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1939549 targets the "4.6.z" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

Requesting review from QA contact:
/cc @xiuwang

Details

In response to this:

WIP - [release-4.5] Bug 1939550: Update tests to use Ruby 2.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan
Copy link
Contributor Author

adambkaplan commented Apr 16, 2021

/hold cancel

Updated to use Ruby 2.6.
Keeping the WIP until I see green runs, or failures that are unrelated to this PR.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 16, 2021 •
edited
Loading

@adambkaplan: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-csi b475646 link /test e2e-aws-csi
ci/prow/e2e-aws b475646 link /test e2e-aws
ci/prow/e2e-agnostic-cmd b475646 link /test e2e-agnostic-cmd
ci/prow/e2e-aws-serial b475646 link /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adambkaplan
Copy link
Contributor Author

adambkaplan commented Apr 26, 2021

/close

Adding this to the list of "test fixes ignored because 4.5 is almost EOL."
Needs #25831 to be cherry picked here as well to fix the perm-fail in e2e-agnostic-cmd.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 26, 2021

@adambkaplan: Closed this PR.

Details

In response to this:

/close

Adding this to the list of "test fixes ignored because 4.5 is almost EOL."
Needs #25831 to be cherry picked here as well to fix the perm-fail in e2e-agnostic-cmd.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 26, 2021

@adambkaplan: This pull request references Bugzilla bug 1939550. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

WIP - [release-4.5] Bug 1939550: Update tests to use Ruby 2.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiuwang xiuwang Awaiting requested review from xiuwang

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

@gabemontero gabemontero

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@adambkaplan @openshift-ci-robot @gabemontero @openshift-bot @xiuwang @markmc @jwforres @openshift-merge-robot