fix the rest of parallel tests working with old token format #26009
Conversation
|
/retest |
1 similar comment
|
/retest |
|
|
||
| privWhoamiOnlyToken, pubWhoamiOnlyToken := exutil.GenerateOAuthTokenPair() | ||
| whoamiOnlyToken := &oauthv1.OAuthAccessToken{ | ||
| ObjectMeta: metav1.ObjectMeta{Name: "whoami-token-plus-some-padding-here-to-make-the-limit-" + oc.Namespace()}, |
There was a problem hiding this comment.
where is "to make the limit" proporty gone? Do we lose anything? Or this just does not matter anymore because we always hash?
There was a problem hiding this comment.
the tokens have a requirement on at least 32 characters length, that's something we're keeping even though it may not make too much sense now that we're using hashed tokens
| oc := exutil.NewCLI("oauth-access-token-e2e-test") | ||
| ctx := context.Background() | ||
|
|
||
| g.It(fmt.Sprintf("accepts classic non-prefixed access tokens"), func() { |
There was a problem hiding this comment.
does this imply an inverse test when we switch over?
A blocker BZ would be good not to forget.
There was a problem hiding this comment.
we won't be able to e2e test that since we won't be able to create such a token, but might still be worth a unit test
Fixes parallel test suite issues that would make the tests fail when the old tokens format is prohibited.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stlaz, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/test e2e-gcp-disruptive |
|
/test e2e-aws-serial |
|
/test e2e-gcp-builds |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
12 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 participants
/assign @sttts