Bug 1970969: clarify failure message #26207
Conversation
|
/retest Upgrade tests didn't seem to hit it |
|
/test e2e-aws-upgrade |
|
cluster-bot's test upgrade 4.7 openshift/origin#26207 gcp shows:
/lgtm |
|
/assign soltysh |
soltysh
left a comment
soltysh
left a comment
There was a problem hiding this comment.
/approve
/retest
@cheesesashimi @vrutkovs you'll need a valid BZ to land it, though
openshift-ci
bot
added
the
approved
|
I'm fine with this merging in 4.9 and being backported later |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Sorry about the lack of a BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1970969. I'm not sure if I opened it against the correct component or not, so please adjust if needed. |
cheesesashimi
changed the title
openshift-ci
bot
added
bugzilla/severity-low
|
@cheesesashimi: This pull request references Bugzilla bug 1970969, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/bugzilla refresh Needs rebase, as I tweaked the error message recently |
|
@vrutkovs: This pull request references Bugzilla bug 1970969, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/valid-bug
The failure message for "[sig-cluster-lifecycle] cluster upgrade should be fast" is ambiguous: upgrade to registry.build01.ci.openshift.org/ci-op-h21l7wld/release@sha256:2148b1c121946ac4f186bb22b166247d3df0ad9cf3966f05dc2a6ea27bc53927 took too long: 86.33481681223333 What does 86.33481681223333 represent? Is it seconds, minutes, hours? What does "too long" mean? Without looking at the test code, one cannot tell. With that info added to the failure string, it's easier to understand: upgrade to registry.build01.ci.openshift.org/ci-op-h21l7wld/release@sha256:2148b1c121946ac4f186bb22b166247d3df0ad9cf3966f05dc2a6ea27bc53927 took too long: 86.3 minutes, expected 75 minutes or less
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Fixed. Also, it looks like the non-AWS upgrade timeout is 75 minutes (https://github.com/openshift/origin/blob/master/test/e2e/upgrade/upgrade.go#L274). I've adjusted the info message from 60m to 75m. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheesesashimi, soltysh, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@cheesesashimi: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@cheesesashimi: All pull requests linked via external trackers have merged: Bugzilla bug 1970969 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
The failure message for "[sig-cluster-lifecycle] cluster upgrade should be fast" is ambiguous:
upgrade to registry.build01.ci.openshift.org/ci-op-h21l7wld/release@sha256:2148b1c121946ac4f186bb22b166247d3df0ad9cf3966f05dc2a6ea27bc53927 took too long: 86.33481681223333
What does 86.33481681223333 represent? Is it seconds, minutes, hours? What does "too long" mean? Without looking at the test code, one cannot tell. With that info added to the failure string, it's easier to understand:
upgrade to registry.build01.ci.openshift.org/ci-op-h21l7wld/release@sha256:2148b1c121946ac4f186bb22b166247d3df0ad9cf3966f05dc2a6ea27bc53927 took too long: 86.3 minutes, expected 75 minutes or less
I'm happy to change verbiage as needed.