Bug 1988264: initializeTestFramework: initialize TextContext ip family #26361

fedepaol · 2021-07-30T08:18:15Z

Some tests rely on the TestContext IPFamily field, that is being initialized in the upstream ginkgo suites but not in origin's one.
Here we add the initialization in initializeTestFramework based on config.HasIPV6 / config.HasIPV4.

This is the manual cherry-pick of #26140

openshift-ci · 2021-07-30T08:18:37Z

@fedepaol: This pull request references Bugzilla bug 1988264, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.z) matches configured target release for branch (4.8.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1956989 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1956989 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

Details

In response to this:

Bug 1988264: initializeTestFramework: initialize TextContext ip family

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fedepaol · 2021-07-30T08:20:42Z

/cc @danwinship

fedepaol · 2021-07-30T08:39:47Z

/hold

danwinship · 2021-07-30T20:22:19Z

/lgtm

fedepaol · 2021-08-04T11:42:55Z

/hold cancel

fedepaol · 2021-08-04T11:43:20Z

/retest

danwinship · 2021-08-19T13:04:20Z

test/extended/util/annotate/rules.go

 			`\[sig-network\]\[Feature:Router\] The HAProxy router should serve the correct routes when scoped to a single namespace and label set`,
 			`\[sig-network\]\[Feature:Router\] The HAProxy router should set Forwarded headers appropriately`,
 			`\[sig-network\]\[Feature:Router\] The HAProxy router should support reencrypt to services backed by a serving certificate automatically`,
+			`\[sig-network\] Networking should provide Internet connection for containers \[Feature:Networking-IPv6\]`,


this needs to remain in [Disabled:Broken] as in #26362

danwinship · 2021-08-23T12:23:06Z

/lgtm cancel
(as above, one of the skips needs to be changed to basically merge in a later fix from master)

Some tests rely on the TestContext IPFamily field, that is being initialized in the upstream ginkgo suites but not in origin's one. Here we add the initialization in initializeTestFramework based on config.HasIPV6 / config.HasIPV4. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>

fedepaol · 2021-08-30T16:49:51Z

/lgtm cancel
(as above, one of the skips needs to be changed to basically merge in a later fix from master)

Done

fedepaol · 2021-08-30T16:50:05Z

@danwinship ptal

openshift-ci · 2021-08-30T20:58:38Z

@fedepaol: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-fips	`2b977c1`	link	`/test e2e-aws-fips`
ci/prow/e2e-aws-upgrade	`2b977c1`	link	`/test e2e-aws-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

danwinship · 2021-09-01T15:57:20Z

/lgtm

openshift-ci · 2021-09-01T15:59:54Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danwinship, fedepaol
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

cmd/OWNERS
test/extended/util/annotate/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ardaguclu · 2021-09-10T13:56:26Z

/test e2e-metal-ipi-ovn-dualstack

openshift-bot · 2021-12-09T22:07:18Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-ci · 2021-12-09T22:08:26Z

@fedepaol: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-01-08T22:27:04Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2022-02-07T22:51:18Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2022-02-07T22:52:48Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-02-07T22:52:54Z

@fedepaol: This pull request references Bugzilla bug 1988264. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Bug 1988264: initializeTestFramework: initialize TextContext ip family

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 30, 2021

openshift-ci bot requested review from pweil- and smarterclayton July 30, 2021 08:20

openshift-ci bot requested a review from danwinship July 30, 2021 08:20

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2021

openshift-ci bot assigned danwinship Jul 30, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2021

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2021

danwinship suggested changes Aug 19, 2021

View reviewed changes

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2021

fedepaol force-pushed the fixipv6tests48 branch from 4ab9942 to 2b977c1 Compare August 30, 2021 16:49

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2021

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 9, 2021

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2021

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 8, 2022

openshift-ci bot closed this Feb 7, 2022

Bug 1988264: initializeTestFramework: initialize TextContext ip family #26361

Bug 1988264: initializeTestFramework: initialize TextContext ip family #26361

Uh oh!

Conversation

fedepaol commented Jul 30, 2021

Uh oh!

openshift-ci bot commented Jul 30, 2021

Uh oh!

fedepaol commented Jul 30, 2021

Uh oh!

fedepaol commented Jul 30, 2021

Uh oh!

danwinship commented Jul 30, 2021

Uh oh!

fedepaol commented Aug 4, 2021

Uh oh!

fedepaol commented Aug 4, 2021

Uh oh!

danwinship Aug 19, 2021

Choose a reason for hiding this comment

Uh oh!

danwinship commented Aug 23, 2021

Uh oh!

fedepaol commented Aug 30, 2021

Uh oh!

fedepaol commented Aug 30, 2021

Uh oh!

openshift-ci bot commented Aug 30, 2021

Uh oh!

danwinship commented Sep 1, 2021

Uh oh!

openshift-ci bot commented Sep 1, 2021

Uh oh!

ardaguclu commented Sep 10, 2021

Uh oh!

openshift-bot commented Dec 9, 2021

Uh oh!

openshift-ci bot commented Dec 9, 2021

Uh oh!

openshift-bot commented Jan 8, 2022

Uh oh!

openshift-bot commented Feb 7, 2022

Uh oh!

openshift-ci bot commented Feb 7, 2022

Uh oh!

openshift-ci bot commented Feb 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants