Skip to content

RUN-1933: test unprivileged builds#27198

Closed
nalind wants to merge 1 commit intoopenshift:masterfrom
nalind:unprivileged-builds
Closed

RUN-1933: test unprivileged builds#27198
nalind wants to merge 1 commit intoopenshift:masterfrom
nalind:unprivileged-builds

Conversation

@nalind
Copy link
Copy Markdown
Member

@nalind nalind commented May 31, 2022

Test builds where we set BUILD_PRIVILEGED=false in the environment to ask the build controller to ask nodes to run builds with fewer privileges.

Verify that builds run with lower privileges by looking for a diagnostic message that the builder logs at log level 2 or higher when it notices that it's running in a user namespace with ID mappings that aren't the node-level default mappings.

Add unprivileged variations to multiple tests that ensure that we can still pass secrets to the builder, and that it can read them properly.

Revise default-privileged cases that assumed the names of builds that now share a BuildConfig with an unprivileged test, since the tests, and their builds, can happen in unexpected sequence.

Depends on openshift/openshift-controller-manager#173.

@openshift-ci openshift-ci Bot requested review from bparees and gabemontero May 31, 2022 19:46
@nalind nalind force-pushed the unprivileged-builds branch 3 times, most recently from ad30e07 to 756be89 Compare June 1, 2022 21:25
@nalind
Copy link
Copy Markdown
Member Author

nalind commented Jun 2, 2022

Whoops, forgot to mark this as a WIP.
/retitle WIP: test unprivileged builds

@openshift-ci openshift-ci Bot changed the title Test unprivileged builds WIP: test unprivileged builds Jun 2, 2022
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2022
@nalind nalind force-pushed the unprivileged-builds branch 13 times, most recently from 4673403 to 1458867 Compare June 9, 2022 21:24
@nalind nalind force-pushed the unprivileged-builds branch 2 times, most recently from 518b5f0 to 8cf4f75 Compare June 10, 2022 19:41
@nalind
Copy link
Copy Markdown
Member Author

nalind commented Jun 13, 2022

/retest

@nalind nalind force-pushed the unprivileged-builds branch 2 times, most recently from 30c7426 to 42769e5 Compare June 14, 2022 14:59
@nalind
Copy link
Copy Markdown
Member Author

nalind commented Jun 15, 2022

Test failures seem to have come down to a missing bit of SELinux policy that would allow us to use kernel overlay, and a kernel-side bug that causes an error when we try to fall back to using fuse-overlayfs. Removing the WIP label.

@nalind nalind changed the title WIP: test unprivileged builds Test unprivileged builds Jun 15, 2022
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2022
@nalind nalind force-pushed the unprivileged-builds branch from 42769e5 to 49f2892 Compare June 23, 2022 13:29
@nalind nalind force-pushed the unprivileged-builds branch 8 times, most recently from fe59ee7 to 2c63e1b Compare October 17, 2023 23:09
@nalind nalind force-pushed the unprivileged-builds branch 2 times, most recently from 0f44d4d to dbb9fc7 Compare October 19, 2023 13:48
@nalind nalind force-pushed the unprivileged-builds branch from dbb9fc7 to 2d21396 Compare October 20, 2023 19:20
@nalind
Copy link
Copy Markdown
Member Author

nalind commented Nov 9, 2023

/retitle RUN-1933: test unprivileged builds

@openshift-ci openshift-ci Bot changed the title Test unprivileged builds RUN-1933: test unprivileged builds Nov 9, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 9, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 9, 2023

@nalind: This pull request references RUN-1933 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Test builds where we set BUILD_PRIVILEGED=false in the environment to ask the build controller to ask nodes to run builds with fewer privileges.

Verify that builds run with lower privileges by looking for a diagnostic message that the builder logs at log level 2 or higher when it notices that it's running in a user namespace with ID mappings that aren't the node-level default mappings.

Add unprivileged variations to multiple tests that ensure that we can still pass secrets to the builder, and that it can read them properly.

Revise default-privileged cases that assumed the names of builds that now share a BuildConfig with an unprivileged test, since the tests, and their builds, can happen in unexpected sequence.

Depends on openshift/openshift-controller-manager#173.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nalind nalind force-pushed the unprivileged-builds branch from 2d21396 to c1a43f2 Compare November 9, 2023 21:58
@nalind
Copy link
Copy Markdown
Member Author

nalind commented Nov 10, 2023

/retest

1 similar comment
@nalind
Copy link
Copy Markdown
Member Author

nalind commented Nov 14, 2023

/retest

@nalind
Copy link
Copy Markdown
Member Author

nalind commented Nov 14, 2023

/skip
/retest

Test builds where we set BUILD_PRIVILEGED=false in the environment to
ask the build controller to ask nodes to run builds with fewer
privileges.

Verify that builds run with lower privileges by looking for a diagnostic
message that the builder logs at log level 2 or higher when it notices
that it's running in a user namespace with ID mappings that aren't the
node-level default mappings.

Add unprivileged variations to multiple tests that ensure that we can
still pass secrets to the builder, and that it can read them properly.

Revise default-privileged cases that assumed the names of builds that
now share a BuildConfig with an unprivileged test, since the tests, and
their builds, can happen in unexpected sequence.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@nalind nalind force-pushed the unprivileged-builds branch from c1a43f2 to 5be597d Compare November 14, 2023 19:47
@nalind
Copy link
Copy Markdown
Member Author

nalind commented Nov 14, 2023

/skip

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 15, 2023

@nalind: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-fips 49f2892 link true /test e2e-aws-fips
ci/prow/e2e-aws-single-node-upgrade 49f2892 link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-gcp 49f2892 link true /test e2e-gcp
ci/prow/e2e-aws-single-node 49f2892 link false /test e2e-aws-single-node
ci/prow/e2e-aws-cgroupsv2 49f2892 link false /test e2e-aws-cgroupsv2
ci/prow/e2e-gcp-builds e2878c4 link true /test e2e-gcp-builds
ci/prow/e2e-gcp-ovn-image-ecosystem e2878c4 link true /test e2e-gcp-ovn-image-ecosystem
ci/prow/e2e-azure-ovn-etcd-scaling d20b236 link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-vsphere-ovn-etcd-scaling d20b236 link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-etcd-scaling d20b236 link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-gcp-ovn-etcd-scaling d20b236 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-openstack-ovn 5be597d link false /test e2e-openstack-ovn
ci/prow/e2e-agnostic-ovn-cmd 5be597d link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-gcp-csi 5be597d link false /test e2e-gcp-csi
ci/prow/e2e-gcp-ovn-upgrade 5be597d link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-gcp-ovn-rt-upgrade 5be597d link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 5be597d link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-upgrade 5be597d link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-csi 5be597d link false /test e2e-aws-csi
ci/prow/e2e-aws-ovn-serial 5be597d link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-cgroupsv2 5be597d link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-gcp-ovn-builds 5be597d link true /test e2e-gcp-ovn-builds
ci/prow/e2e-metal-ipi-sdn 5be597d link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node 5be597d link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-ovn 5be597d link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-single-node-serial 5be597d link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 5be597d link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-fips 5be597d link true /test e2e-aws-ovn-fips

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nalind
Copy link
Copy Markdown
Member Author

nalind commented Nov 28, 2023

/skip

@openshift-bot
Copy link
Copy Markdown
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 27, 2024
@openshift-bot
Copy link
Copy Markdown
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-bot
Copy link
Copy Markdown
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2024

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants