RUN-1933: test unprivileged builds#27198
Conversation
ad30e07 to
756be89
Compare
|
Whoops, forgot to mark this as a WIP. |
4673403 to
1458867
Compare
518b5f0 to
8cf4f75
Compare
|
/retest |
30c7426 to
42769e5
Compare
|
Test failures seem to have come down to a missing bit of SELinux policy that would allow us to use kernel overlay, and a kernel-side bug that causes an error when we try to fall back to using fuse-overlayfs. Removing the WIP label. |
42769e5 to
49f2892
Compare
fe59ee7 to
2c63e1b
Compare
0f44d4d to
dbb9fc7
Compare
dbb9fc7 to
2d21396
Compare
|
/retitle RUN-1933: test unprivileged builds |
|
@nalind: This pull request references RUN-1933 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2d21396 to
c1a43f2
Compare
|
/retest |
1 similar comment
|
/retest |
|
/skip |
Test builds where we set BUILD_PRIVILEGED=false in the environment to ask the build controller to ask nodes to run builds with fewer privileges. Verify that builds run with lower privileges by looking for a diagnostic message that the builder logs at log level 2 or higher when it notices that it's running in a user namespace with ID mappings that aren't the node-level default mappings. Add unprivileged variations to multiple tests that ensure that we can still pass secrets to the builder, and that it can read them properly. Revise default-privileged cases that assumed the names of builds that now share a BuildConfig with an unprivileged test, since the tests, and their builds, can happen in unexpected sequence. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
c1a43f2 to
5be597d
Compare
|
/skip |
|
@nalind: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/skip |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Test builds where we set BUILD_PRIVILEGED=false in the environment to ask the build controller to ask nodes to run builds with fewer privileges.
Verify that builds run with lower privileges by looking for a diagnostic message that the builder logs at log level 2 or higher when it notices that it's running in a user namespace with ID mappings that aren't the node-level default mappings.
Add unprivileged variations to multiple tests that ensure that we can still pass secrets to the builder, and that it can read them properly.
Revise default-privileged cases that assumed the names of builds that now share a BuildConfig with an unprivileged test, since the tests, and their builds, can happen in unexpected sequence.
Depends on openshift/openshift-controller-manager#173.