Update authenticated users RBAC e2e test#27326
Update authenticated users RBAC e2e test#27326openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
Conversation
07a7704 to
1be7bac
Compare
ibihim
left a comment
There was a problem hiding this comment.
We are adding a rule.
Is there some link to a PR (feature / test cases) that will make tests break?
1be7bac to
bf9321f
Compare
@ibihim there is an OLM PR that cannot merge because the testcase changed in this PR fails because authenticated users have unexpected permissions. The OLM PR doesn't test that authenticated users have these permissions, but console will be updating it's operatorhub page to be built using the CSVs in the openshift namespace. This redesign will be tested and will fail if authenticated users lack the RBAC introduced in this PR. I can add a testcase to the OLM e2e suite to check for these permissions, but it seems redundant given the planned console work. Let me know what you think. |
bf9321f to
711e05a
Compare
Problem: OLM has historically communicated to users which operators are available in a given namespace by creating a copy of an operator CSV in each namespace that it is scoped to. This has caused performance issues on large clusters with many namespaces. OLM provided users with the means to disable Copied CSVs for operators scoped to all namespaces, but console was unable to communicate which operators were available globally. Console will look for csvs in the openshift namespace to identify which operators are available globally for authenticated users. The authenticated user group needs read permissions to view the CSVs in the openshift namespace. The extended e2e origin test suite has a test that ensures that authenticated users do not have unanticipated RBAC. Solution: This commit updates the test so that it expects the authenticated user group to have get, list, and watch permissions on CSVs in the openshift namespace.
711e05a to
3a3a3a4
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, deads2k, ibihim The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@awgreene: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Problem: OLM has historically communicated to users which operators
are available in a given namespace by creating a copy of an operator
CSV in each namespace that it is scoped to. This has caused performance
issues on large clusters with many namespaces. OLM provided users with
the means to disable Copied CSVs for operators scoped to all namespaces,
but console was unable to communicate which operators were available
globally. Console will look for csvs in the openshift namespace to
identify which operators are available globally for authenticated users.
The authenticated user group needs read permissions to view the
CSVs in the openshift namespace. The extended e2e origin test suite has
a test that ensures that authenticated users do not have unanticipated
RBAC.
Solution: This commit updates the test so that it expects the authenticated
user group to have get, list, and watch permissions on CSVs in the openshift
namespace.