Add bond cni test #27405

mmirecki · 2022-09-07T10:42:59Z

Adding a test case for the bond-cni.
The test checks if a pod with a bond is created successfully, and then checks connectivity between two pods with bond interfaces.

mmirecki · 2022-09-08T06:58:28Z

/retest-required

mmirecki · 2022-09-08T09:01:48Z

@dougbtv could you please take a look, thx

mmirecki · 2022-09-08T13:54:12Z

/retest-required

mmirecki · 2022-09-08T17:41:49Z

/retest-required

mmirecki · 2022-09-09T07:05:14Z

/retest-required

dougbtv

/lgtm

mmirecki · 2022-09-15T10:18:21Z

/assign @mfojtik

mmirecki · 2022-09-19T12:02:20Z

@dougbtv Can we merge this?

maiqueb

Some nits, but I think at least the imports should be organized.

Also, the HaveLen matcher gives better output when it fails.

test/extended/networking/bonds.go

maiqueb

Thanks.

Left some more nits you can choose to adopt, or ignore.

test/extended/networking/bonds.go

maiqueb

/lgtm

cgoncalves · 2022-10-21T09:25:49Z

@danwinship could you please revisit this PR? I believe Marcin addressed your previous comments. Thank you!

dougbtv · 2022-10-21T12:12:56Z

/approve

knobunc · 2022-10-21T12:27:51Z

/approve

openshift-ci-robot · 2022-10-22T22:09:17Z

/retest-required

Remaining retests: 0 against base HEAD 6f17d51 and 2 for PR HEAD 786b575 in total

cgoncalves · 2022-10-27T07:05:16Z

/retest-required

Adding a test case for the bond-cni. The test checks if a pod with a bond is created successfully, and then checks connectivity between two pods with bond interfaces.

mmirecki · 2022-10-31T11:16:29Z

/retest-required

cgoncalves · 2022-11-02T10:25:56Z

/lgtm

openshift-ci · 2022-11-02T10:29:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgoncalves, dougbtv, knobunc, maiqueb, mmirecki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [knobunc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mmirecki · 2022-11-02T11:22:30Z

/retest-required

mmirecki · 2022-11-02T14:26:01Z

/retest-required

openshift-ci · 2022-11-02T19:52:33Z

@mmirecki: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn-rt-upgrade	`dbd929d`	link	false	`/test e2e-gcp-ovn-rt-upgrade`
ci/prow/e2e-aws-ovn-single-node-upgrade	`dbd929d`	link	false	`/test e2e-aws-ovn-single-node-upgrade`
ci/prow/e2e-metal-ipi-sdn	`dbd929d`	link	false	`/test e2e-metal-ipi-sdn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mmirecki · 2022-11-03T07:26:16Z

/retest-required

mmirecki · 2022-11-03T12:45:06Z

/retest-required

mmirecki · 2022-11-04T16:27:07Z

/cherrypick release-4.12

openshift-cherrypick-robot · 2022-11-04T16:29:17Z

@mmirecki: new pull request created: #27524

Details

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mmirecki · 2022-11-09T08:59:06Z

/cherrypick release-4.12

openshift-cherrypick-robot · 2022-11-09T09:02:05Z

@mmirecki: #27405 failed to apply on top of branch "release-4.12":

Applying: Add bond cni test
.git/rebase-apply/patch:249: trailing whitespace.
		"mode": "active-backup", 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	test/extended/networking/util.go
M	test/extended/util/annotate/generated/zz_generated.annotations.go
A	vendor/github.com/emicklei/go-restful/.gitignore
A	vendor/github.com/emicklei/go-restful/CHANGES.md
A	vendor/github.com/emicklei/go-restful/README.md
A	vendor/github.com/emicklei/go-restful/container.go
A	vendor/github.com/emicklei/go-restful/curly.go
A	vendor/github.com/emicklei/go-restful/path_processor.go
A	vendor/github.com/emicklei/go-restful/route.go
A	vendor/github.com/emicklei/go-restful/web_service.go
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Removing vendor/github.com/fsnotify/fsnotify/.travis.yml
Auto-merging vendor/github.com/emicklei/go-restful/v3/web_service.go
CONFLICT (content): Merge conflict in vendor/github.com/emicklei/go-restful/v3/web_service.go
Auto-merging vendor/github.com/emicklei/go-restful/v3/route.go
CONFLICT (content): Merge conflict in vendor/github.com/emicklei/go-restful/v3/route.go
Auto-merging vendor/github.com/emicklei/go-restful/v3/path_processor.go
CONFLICT (content): Merge conflict in vendor/github.com/emicklei/go-restful/v3/path_processor.go
Auto-merging vendor/github.com/emicklei/go-restful/v3/curly.go
Auto-merging vendor/github.com/emicklei/go-restful/v3/container.go
CONFLICT (content): Merge conflict in vendor/github.com/emicklei/go-restful/v3/container.go
Auto-merging vendor/github.com/emicklei/go-restful/v3/README.md
Auto-merging vendor/github.com/emicklei/go-restful/v3/CHANGES.md
CONFLICT (content): Merge conflict in vendor/github.com/emicklei/go-restful/v3/CHANGES.md
Auto-merging vendor/github.com/emicklei/go-restful/v3/.gitignore
Auto-merging test/extended/util/annotate/generated/zz_generated.annotations.go
CONFLICT (content): Merge conflict in test/extended/util/annotate/generated/zz_generated.annotations.go
Auto-merging test/extended/networking/util.go
CONFLICT (content): Merge conflict in test/extended/networking/util.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add bond cni test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from knobunc and soltysh September 7, 2022 10:46

openshift-ci bot added the vendor-update Touching vendor dir or related files label Sep 7, 2022

mmirecki force-pushed the bond_test branch 2 times, most recently from e9acb13 to 06b7b9f Compare September 7, 2022 10:51

mmirecki force-pushed the bond_test branch from 06b7b9f to 4b8689d Compare September 8, 2022 10:15

dougbtv approved these changes Sep 9, 2022

View reviewed changes

openshift-ci bot assigned dougbtv Sep 9, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2022

openshift-ci bot assigned mfojtik Sep 15, 2022

maiqueb suggested changes Sep 21, 2022

View reviewed changes

test/extended/networking/bonds.go Outdated Show resolved Hide resolved

test/extended/networking/bonds.go Outdated Show resolved Hide resolved

test/extended/networking/bonds.go Outdated Show resolved Hide resolved

maiqueb reviewed Sep 21, 2022

View reviewed changes

test/extended/networking/bonds.go Show resolved Hide resolved

mmirecki force-pushed the bond_test branch from 4b8689d to 7464142 Compare September 21, 2022 09:04

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2022

maiqueb reviewed Sep 21, 2022

View reviewed changes

test/extended/networking/bonds.go Outdated Show resolved Hide resolved

maiqueb reviewed Sep 21, 2022

View reviewed changes

test/extended/networking/bonds.go Show resolved Hide resolved

maiqueb approved these changes Sep 21, 2022

View reviewed changes

mmirecki force-pushed the bond_test branch from 7464142 to 68863f4 Compare September 21, 2022 09:51

maiqueb reviewed Sep 21, 2022

View reviewed changes

test/extended/networking/bonds.go Outdated Show resolved Hide resolved

mmirecki force-pushed the bond_test branch from 68863f4 to f07878b Compare September 21, 2022 09:59

maiqueb approved these changes Sep 21, 2022

View reviewed changes

openshift-ci bot assigned maiqueb Sep 21, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2022

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2022

mmirecki force-pushed the bond_test branch from 786b575 to beb5e7d Compare October 24, 2022 08:35

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2022

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2022

mmirecki force-pushed the bond_test branch from beb5e7d to 0d57fdc Compare October 28, 2022 10:23

Add bond cni test

dbd929d

Adding a test case for the bond-cni. The test checks if a pod with a bond is created successfully, and then checks connectivity between two pods with bond interfaces.

mmirecki force-pushed the bond_test branch from 0d57fdc to dbd929d Compare October 31, 2022 10:01

openshift-ci bot assigned cgoncalves Nov 2, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2022

openshift-merge-robot merged commit 0cfad9d into openshift:master Nov 3, 2022

openshift-cherrypick-robot mentioned this pull request Nov 4, 2022

[release-4.12] Add bond cni test #27524

Closed

mmirecki mentioned this pull request Nov 9, 2022

[release-4.12] Add bond cni test #27536

Closed

Add bond cni test #27405

Add bond cni test #27405

Uh oh!

Conversation

mmirecki commented Sep 7, 2022

Uh oh!

mmirecki commented Sep 8, 2022

Uh oh!

mmirecki commented Sep 8, 2022

Uh oh!

mmirecki commented Sep 8, 2022

Uh oh!

mmirecki commented Sep 8, 2022

Uh oh!

mmirecki commented Sep 9, 2022

Uh oh!

dougbtv left a comment

Choose a reason for hiding this comment

Uh oh!

mmirecki commented Sep 15, 2022

Uh oh!

mmirecki commented Sep 19, 2022

Uh oh!

maiqueb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maiqueb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maiqueb left a comment

Choose a reason for hiding this comment

Uh oh!

cgoncalves commented Oct 21, 2022

Uh oh!

dougbtv commented Oct 21, 2022

Uh oh!

knobunc commented Oct 21, 2022

Uh oh!

openshift-ci-robot commented Oct 22, 2022

Uh oh!

cgoncalves commented Oct 27, 2022

Uh oh!

mmirecki commented Oct 31, 2022

Uh oh!

cgoncalves commented Nov 2, 2022

Uh oh!

openshift-ci bot commented Nov 2, 2022

Uh oh!

mmirecki commented Nov 2, 2022

Uh oh!

mmirecki commented Nov 2, 2022

Uh oh!

openshift-ci bot commented Nov 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmirecki commented Nov 3, 2022

Uh oh!

mmirecki commented Nov 3, 2022

Uh oh!

mmirecki commented Nov 4, 2022

Uh oh!

openshift-cherrypick-robot commented Nov 4, 2022

Uh oh!

mmirecki commented Nov 9, 2022

Uh oh!

openshift-cherrypick-robot commented Nov 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

openshift-ci bot commented Nov 2, 2022 •

edited

Loading