USHIFT-355: MicroShift: skip sig-network tests #27428

pacevedom · 2022-09-19T15:53:34Z

No description provided.

jaypoulz · 2022-09-19T18:20:41Z

test/extended/util/framework.go

+
+var (
+	microShiftVersion string
+	microShiftMutex   sync.Mutex


What is this protecting against?

pacevedom · 2022-09-23T14:34:00Z

/hold
Need to get rid of microshift checks.

pacevedom · 2022-09-26T06:12:36Z

/unhold

ingvagabund · 2022-09-29T10:01:08Z

test/extended/idling/idling.go

 	})

-	g.Describe("Unidling", func() {
+	g.Describe("Unidling [apigroup:apps.openshift.io]", func() {


route.openshift.io as well (both apps and route are used in testdata/idling-echo-server.yaml (set through echoServerFixture)

Also with a single service and DeploymentConfig (line 218) is using route.openshift.io (through testdata/idling-echo-server-rc.yaml)

ingvagabund · 2022-09-29T10:12:18Z

test/extended/router/stress.go

-		}, metav1.CreateOptions{})
+		}
+
+		_, err = oc.AdminKubeClient().RbacV1().RoleBindings(ns).Create(context.Background(), roleBinding, metav1.CreateOptions{})


Why this change when roleBinding is used only once?

Leftover from previous change.

ingvagabund · 2022-09-29T10:14:37Z

test/extended/util/framework.go

 }

 func FindRouterImage(oc *CLI) (string, error) {
+	microShift, err := IsMicroShiftDeployment(oc)


Leftover? IsMicroShiftDeployment is never defined.

ingvagabund · 2022-10-04T10:37:51Z

test/extended/util/framework.go

+		return "", err
+	}
+	if !exists {
+		deployment, err := oc.AdminKubeClient().AppsV1().Deployments("openshift-ingress").Get(context.Background(), "router-default", metav1.GetOptions{})


In 4.12 taking deployment.Spec.Template.Spec.Containers[0].Image from the deployment gets me quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:a955bf1686fcb4f11cd23880be6025c2dc75252d318931211554be86f4f5d0f1. Taking .Status.Versions[*].Version from clusteroperator/ingress I get quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:a955bf1686fcb4f11cd23880be6025c2dc75252d318931211554be86f4f5d0f1. @pacevedom is it always guaranteed the images will be identical?

@openshift/networking can you confirm accessing deployment.Spec.Template.Spec.Containers[0].Image of router-default deployment gets the same image as from the ingress clusteroperator object? Resp. is this acceptable alternative?

Yes, deployment.Spec.Template.Spec.Containers[0].Image of the openshift-ingress/router-default deployment on both MicroShift and standard OpenShift is the same image as the "ingress-controller" image in the ingress clusteroperator on standard OpenShift. This approach looks reasonable.

This is output from a 4.12 cluster:

$ oc get deployment -n openshift-ingress router-default -o jsonpath='{.spec.template.spec.containers[*].image}' quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:72c751aa148bf498839e6f37b304e3265f85af1e00578e637332a13ed9545ece $ oc get clusteroperator ingress -o jsonpath='{.status.versions[?(@.name=="ingress-controller")].version}' quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:72c751aa148bf498839e6f37b304e3265f85af1e00578e637332a13ed9545ece

router-default is MicroShift equivalent for ingress-controller pod in OCP.

ingvagabund · 2022-10-04T14:01:33Z

/lgtm
based on #27428 (comment)

soltysh

/approve

pacevedom · 2022-10-04T14:19:09Z

/retest-required

openshift-ci-robot · 2022-10-04T16:36:51Z

/retest-required

Remaining retests: 0 against base HEAD 9edb6c7 and 2 for PR HEAD 0feb162 in total

pacevedom · 2022-10-04T19:12:09Z

/retest-required

openshift-ci-robot · 2022-10-04T21:38:45Z

/retest-required

Remaining retests: 0 against base HEAD efd2179 and 1 for PR HEAD 0feb162 in total

openshift-ci-robot · 2022-10-05T02:38:41Z

/retest-required

Remaining retests: 0 against base HEAD 703e3d1 and 0 for PR HEAD 0feb162 in total

openshift-ci-robot · 2022-10-05T04:38:31Z

/hold

Revision 0feb162 was retested 3 times: holding

pacevedom · 2022-10-05T06:00:36Z

/unhold
/retest-required

openshift-ci-robot · 2022-10-05T08:38:44Z

/retest-required

Remaining retests: 0 against base HEAD 703e3d1 and 2 for PR HEAD 0feb162 in total

pacevedom · 2022-10-05T09:51:55Z

/retest-required

openshift-ci-robot · 2022-10-22T22:09:18Z

/retest-required

Remaining retests: 0 against base HEAD 6f17d51 and 2 for PR HEAD 0feb162 in total

ingvagabund · 2022-10-24T09:25:45Z

tools/junitreport/pkg/parser/gotest/data_parser_test.go

 		{
-			name:         "basic",
-			testLine:     "ok  	package/name 0.160s",
+			name: "basic",


Looks like this is formatted with go1.18. @pacevedom the codebase has been recently formatted with go1.19.

ingvagabund · 2022-10-26T09:49:22Z

/lgtm

ingvagabund · 2022-10-26T13:00:04Z

/lgtm

openshift-ci · 2022-10-26T13:01:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, pacevedom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pmtk · 2022-10-26T16:21:46Z

/retest-required

openshift-ci · 2022-10-26T19:51:54Z

@pacevedom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-ovn-cmd	`8d9355e`	link	false	`/test e2e-agnostic-ovn-cmd`
ci/prow/e2e-gcp-ovn-rt-upgrade	`8d9355e`	link	false	`/test e2e-gcp-ovn-rt-upgrade`
ci/prow/e2e-aws-ovn-serial	`8d9355e`	link	true	`/test e2e-aws-ovn-serial`
ci/prow/e2e-aws-ovn-single-node	`8d9355e`	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/e2e-aws-ovn-single-node-serial	`8d9355e`	link	false	`/test e2e-aws-ovn-single-node-serial`
ci/prow/e2e-gcp-csi	`8d9355e`	link	false	`/test e2e-gcp-csi`
ci/prow/e2e-aws-csi	`8d9355e`	link	false	`/test e2e-aws-csi`
ci/prow/e2e-metal-ipi-ovn-ipv6	`8d9355e`	link	false	`/test e2e-metal-ipi-ovn-ipv6`
ci/prow/e2e-aws-ovn-fips	`8d9355e`	link	true	`/test e2e-aws-ovn-fips`
ci/prow/e2e-openstack-ovn	`8d9355e`	link	false	`/test e2e-openstack-ovn`
ci/prow/e2e-metal-ipi-sdn	`8d9355e`	link	false	`/test e2e-metal-ipi-sdn`
ci/prow/e2e-aws-ovn-cgroupsv2	`8d9355e`	link	false	`/test e2e-aws-ovn-cgroupsv2`
ci/prow/e2e-gcp-ovn	`8d9355e`	link	true	`/test e2e-gcp-ovn`
ci/prow/e2e-aws-ovn-single-node-upgrade	`8d9355e`	link	false	`/test e2e-aws-ovn-single-node-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ingvagabund · 2022-10-26T20:08:24Z

From https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/27428/pull-ci-openshift-origin-master-e2e-aws-ovn-fips/1585305880637739008:

[sig-network-edge][Feature:Idling] Unidling [apigroup:apps.openshift.io][apigroup:route.openshift.io] should handle many TCP connections by possibly dropping those over a certain bound [Serial] [Suite:openshift/conformance/serial] is constantly failing. Because it's originally skipped by the name changed: https://github.com/openshift/origin/blob/master/test/extended/util/annotate/rules.go#L68 and https://github.com/openshift/origin/blob/master/test/extended/util/annotate/rules.go#L307-L308

ingvagabund · 2022-10-27T14:55:45Z

Merged through #27498

openshift-merge-robot · 2022-10-27T14:56:15Z

@pacevedom: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ingvagabund · 2022-10-27T14:56:15Z

/close

openshift-ci · 2022-10-27T15:01:33Z

@ingvagabund: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from gabemontero and jaypoulz September 19, 2022 15:55

jaypoulz reviewed Sep 19, 2022

View reviewed changes

pacevedom force-pushed the ushift-sig-network branch from d12069a to 32ae026 Compare September 23, 2022 08:34

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2022

pacevedom force-pushed the ushift-sig-network branch from 32ae026 to 9f3ba3c Compare September 26, 2022 06:12

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2022

ingvagabund reviewed Sep 29, 2022

View reviewed changes

pacevedom force-pushed the ushift-sig-network branch from 9f3ba3c to 0feb162 Compare September 29, 2022 15:17

ingvagabund reviewed Oct 4, 2022

View reviewed changes

soltysh approved these changes Oct 4, 2022

View reviewed changes

openshift-ci bot assigned ingvagabund Oct 4, 2022

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 4, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2022

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2022

pacevedom force-pushed the ushift-sig-network branch from 0feb162 to 04103fc Compare October 24, 2022 09:17

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2022

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2022

ingvagabund reviewed Oct 24, 2022

View reviewed changes

pacevedom force-pushed the ushift-sig-network branch from 04103fc to 153f716 Compare October 24, 2022 13:07

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2022

pacevedom force-pushed the ushift-sig-network branch from 153f716 to f334707 Compare October 24, 2022 13:31

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2022

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2022

microshift: skip sig-network tests

8d9355e

pacevedom force-pushed the ushift-sig-network branch from f334707 to 8d9355e Compare October 26, 2022 12:13

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2022

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2022

ingvagabund mentioned this pull request Oct 26, 2022

MicroShift: label e2es with more apigroup labels (squashing more PRs into a single one + fixes) #27498

Merged

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2022

openshift-ci bot closed this Oct 27, 2022

USHIFT-355: MicroShift: skip sig-network tests #27428

USHIFT-355: MicroShift: skip sig-network tests #27428

Uh oh!

Conversation

pacevedom commented Sep 19, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pacevedom commented Sep 23, 2022

Uh oh!

pacevedom commented Sep 26, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ingvagabund Oct 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Miciah Oct 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ingvagabund commented Oct 4, 2022

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

pacevedom commented Oct 4, 2022

Uh oh!

openshift-ci-robot commented Oct 4, 2022

Uh oh!

pacevedom commented Oct 4, 2022

Uh oh!

openshift-ci-robot commented Oct 4, 2022

Uh oh!

openshift-ci-robot commented Oct 5, 2022

Uh oh!

openshift-ci-robot commented Oct 5, 2022

Uh oh!

pacevedom commented Oct 5, 2022

Uh oh!

openshift-ci-robot commented Oct 5, 2022

Uh oh!

pacevedom commented Oct 5, 2022

Uh oh!

openshift-ci-robot commented Oct 22, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ingvagabund commented Oct 26, 2022

Uh oh!

ingvagabund commented Oct 26, 2022

Uh oh!

openshift-ci bot commented Oct 26, 2022

Uh oh!

pmtk commented Oct 26, 2022

Uh oh!

openshift-ci bot commented Oct 26, 2022

Uh oh!

ingvagabund commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ingvagabund commented Oct 27, 2022

Uh oh!

ingvagabund Oct 4, 2022 •

edited

Loading

Miciah Oct 4, 2022 •

edited

Loading

ingvagabund commented Oct 26, 2022 •

edited

Loading