Skip to content

Bug 2093339: Reenable data source test #27534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 21, 2022
Merged

Bug 2093339: Reenable data source test #27534

openshift-merge-robot merged 1 commit into from
Nov 21, 2022

Conversation

@bertinatto
Copy link
Member

@bertinatto bertinatto commented Nov 8, 2022

This test was introduced in k8s v1.24 and disabled here because it was pulling an image from a hardcoded registry.

Since this has been fixed in upstream and landed here through the 1.25 rebase [1], reenable it.

[1] #27526

CC @openshift/storage

@bertinatto
Re-enable data source test
0086f22 
This test was introduced in k8s v1.24 and disabled here
because it was pulling an image from a hardcoded registry.

Since this has been fixed in upstream, I\'m re-enabling it here.
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2022

@bertinatto: This pull request references Bugzilla bug 2093339, which is invalid:

  • expected the bug to target the "4.13.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2093339: Reenable data source test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jmguzik and mrogers950 November 8, 2022 17:49
@bertinatto
Copy link
Member Author

bertinatto commented Nov 8, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2022

@bertinatto: This pull request references Bugzilla bug 2093339, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.13.0) matches configured target release for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto
Copy link
Member Author

bertinatto commented Nov 9, 2022

Passed: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/27534/pull-ci-openshift-origin-master-e2e-aws-ovn-serial/1590038637561516032

@dgoodwin
Copy link
Contributor

dgoodwin commented Nov 21, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, dgoodwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2022

/retest-required

Remaining retests: 0 against base HEAD 403f0a4 and 2 for PR HEAD 0086f22 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2022 •
edited
Loading

@bertinatto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 0086f22 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-upgrade 0086f22 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 0086f22 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-openstack-ovn 0086f22 link false /test e2e-openstack-ovn
ci/prow/e2e-agnostic-ovn-cmd 0086f22 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-metal-ipi-ovn-ipv6 0086f22 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ipi-sdn 0086f22 link false /test e2e-metal-ipi-sdn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bertinatto
Copy link
Member Author

bertinatto commented Nov 21, 2022

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit c060ca4 into openshift:master Nov 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2022

@bertinatto: All pull requests linked via external trackers have merged:

Bugzilla bug 2093339 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2093339: Reenable data source test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmguzik jmguzik Awaiting requested review from jmguzik

@mrogers950 mrogers950 Awaiting requested review from mrogers950

Assignees

@dgoodwin dgoodwin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bertinatto @dgoodwin @openshift-ci-robot @openshift-merge-robot