Skip to content

Conversation

@dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Nov 14, 2022

TRT-674

This reverts commit a747f94, reversing
changes made to 63e7542.

There appears to be a problem with recording flakes, none in 4.13 jobs since Nov 4th. There was some odd flaking code I moved here, but tried to maintain compatibility. I suspect some of the magic involved in reporting a flake for the currently running test doesn't work if you move the code for some reason.

Due to this we're now failing payloads because we don't get enough results, I think because we usually flake this test and now are below 6 results because those don't get recorded.

4.12 is more confusing, this code should be live there, payloads are failing the same way, but I do still see some flakes getting reported in 4.12 jobs...

…backstops"

This reverts commit a747f94, reversing
changes made to 63e7542.
@openshift-ci openshift-ci bot requested review from bparees and mrogers950 November 14, 2022 13:00
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2022
@stbenjam
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dgoodwin dgoodwin changed the title Revert "Merge pull request #27533 from dgoodwin/merge-alert-backstops" OCPBUGS-3633: Revert "Merge pull request #27533 from dgoodwin/merge-alert-backstops" Nov 14, 2022
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 14, 2022
@openshift-ci-robot
Copy link

@dgoodwin: This pull request references Jira Issue OCPBUGS-3633, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

TRT-674

This reverts commit a747f94, reversing
changes made to 63e7542.

There appears to be a problem with recording flakes, none in 4.13 jobs since Nov 4th. There was some odd flaking code I moved here, but tried to maintain compatibility. I suspect some of the magic involved in reporting a flake for the currently running test doesn't work if you move the code for some reason.

Due to this we're now failing payloads because we don't get enough results, I think because we usually flake this test and now are below 6 results because those don't get recorded.

4.12 is more confusing, this code should be live there, payloads are failing the same way, but I do still see some flakes getting reported in 4.12 jobs...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@dgoodwin: This pull request references Jira Issue OCPBUGS-3633, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member

/cherry-pick release-4.12
/jira refresh

@openshift-cherrypick-robot

@stbenjam: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.12
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 14, 2022
@openshift-ci-robot
Copy link

@stbenjam: This pull request references Jira Issue OCPBUGS-3633, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/cherry-pick release-4.12
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member

/skip
/override ci/prow/e2e-gcp-ovn-builds
/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2022

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-builds

Details

In response to this:

/skip
/override ci/prow/e2e-gcp-ovn-builds
/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin
Copy link
Contributor Author

dgoodwin commented Nov 14, 2022

Bot seems a little confused. Says it's still waiting on these but they were successfully run.

/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-gcp-ovn-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2022

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-gcp-ovn-upgrade

Details

In response to this:

Bot seems a little confused. Says it's still waiting on these but they were successfully run.

/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-serial ci/prow/e2e-gcp-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2022

@dgoodwin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade 8ec4f2a link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-openstack-ovn 8ec4f2a link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-upgrade 8ec4f2a link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 8ec4f2a link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-agnostic-ovn-cmd 8ec4f2a link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-single-node 8ec4f2a link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 10442fb into openshift:master Nov 14, 2022
@openshift-ci-robot
Copy link

@dgoodwin: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-3633 has been moved to the MODIFIED state.

Details

In response to this:

TRT-674

This reverts commit a747f94, reversing
changes made to 63e7542.

There appears to be a problem with recording flakes, none in 4.13 jobs since Nov 4th. There was some odd flaking code I moved here, but tried to maintain compatibility. I suspect some of the magic involved in reporting a flake for the currently running test doesn't work if you move the code for some reason.

Due to this we're now failing payloads because we don't get enough results, I think because we usually flake this test and now are below 6 results because those don't get recorded.

4.12 is more confusing, this code should be live there, payloads are failing the same way, but I do still see some flakes getting reported in 4.12 jobs...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@stbenjam: new pull request created: #27550

Details

In response to this:

/cherry-pick release-4.12
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin dgoodwin deleted the revert-alert-test-merger branch November 16, 2022 13:27
dgoodwin added a commit to dgoodwin/origin that referenced this pull request Nov 16, 2022
…-test-merger"

This reverts commit 10442fb, reversing
changes made to ceb552b.
tjungblu pushed a commit to tjungblu/origin that referenced this pull request Apr 11, 2023
…-test-merger"

This reverts commit 10442fb, reversing
changes made to ceb552b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants