disruption: alwaysAllowOneSecond should always allow one second #27581
Conversation
I have an example of an NPE on this code[1] -- alwaysAllowOneSecond should always return one second but there is a case where it can return nil, which causes a null pointer error later on. [1] https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.13-e2e-metal-ipi-upgrade-ovn-ipv6/1597863031415508992
|
/hold #27574 also identified this problem and took a different approach to solve it. It may be correct to let alwaysAllowOneSecond to return nil to mean "no data at all." |
openshift-ci
bot
added
the
do-not-merge/hold
|
/close |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@stbenjam: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 participant
I have an example of an NPE on this code[1] -- alwaysAllowOneSecond should always return one second but there is a case where it can return nil, which causes a null pointer error later on.
[1] https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.13-e2e-metal-ipi-upgrade-ovn-ipv6/1597863031415508992