[release-4.12] OCPBUGS-6841: Update etcd scaling test for CPMS supported platforms #27692

openshift-cherrypick-robot · 2023-01-27T21:53:50Z

This is an automated cherry-pick of #27497

/assign hasbro17

For platforms where the ControlPlaneMachineSet is active and being reconciled by the CPMSO, the vertical scaling test should rely on the CPMSO to remove and add new machines, otherwise there is a race between the test removing a machine and the CPMSO adding a new one.

Elbehery · 2023-01-31T14:05:16Z

/retest-required

Elbehery · 2023-01-31T14:05:26Z

/lgtm
/approve

Elbehery · 2023-01-31T14:11:13Z

/retitle [release-4.12] OCPBUGS-6841: Update etcd scaling test for CPMS supported platforms

openshift-ci-robot · 2023-01-31T14:11:44Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-6841, which is invalid:

expected Jira Issue OCPBUGS-6841 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #27497

/assign hasbro17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-01-31T14:11:57Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] OCPBUGS-6841: Update etcd scaling test for CPMS supported platforms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Elbehery · 2023-01-31T14:20:55Z

/jira refresh

Elbehery · 2023-01-31T14:21:06Z

cc @tjungblu

openshift-ci-robot · 2023-01-31T14:21:06Z

@Elbehery: This pull request references Jira Issue OCPBUGS-6841, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.z) matches configured target version for branch (4.12.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-6844 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-6844 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
bug has dependents

Requesting review from QA contact:
/cc @geliu2016

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Elbehery · 2023-01-31T16:23:29Z

@hasbro17 do we need to override sth here ?

geliu2016

/label cherry-pick-approved

openshift-ci · 2023-02-01T02:20:08Z

@geliu2016: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-staff-engineers]

Details

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-02-01T02:20:14Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elbehery, geliu2016, openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please ask for approval from hasbro17 by writing /assign @hasbro17 in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

test/extended/etcd/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hasbro17 · 2023-02-01T19:45:15Z

Yeah the scaling test itself is passing on all platforms as with 4.13. The job failure is due to the pathological events failure, and an unrelated prometheus alerting setup error:
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/27692/pull-ci-openshift-origin-release-4.12-e2e-vsphere-ovn-etcd-scaling/1619091368712343552

Suite run returned error: AlertErr: Thanos queriers not connected to all Prometheus sidecars: server_error: server error: 504
error: AlertErr: Thanos queriers not connected to all Prometheus sidecars: server_error: server error: 504

/retest-required

Elbehery · 2023-02-01T23:15:22Z

/retest-required

Elbehery · 2023-02-01T23:38:46Z

test/extended/etcd/helpers/helpers.go

+// this effectively counts the number of control-plane machines with the provider state as running
+func EnsureReadyReplicasOnCPMS(ctx context.Context, t TestingT, expectedReplicaCount int, cpmsClient machinev1client.ControlPlaneMachineSetInterface) error {
+	waitPollInterval := 5 * time.Second
+	waitPollTimeout := 10 * time.Minute


Suggested change

waitPollTimeout := 10 * time.Minute

waitPollTimeout := 18 * time.Minute

can u just commit this @hasbro17

Elbehery · 2023-02-02T06:58:46Z

/retest-required

openshift-ci · 2023-02-02T09:17:53Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-sdn	`b05b30e`	link	false	`/test e2e-metal-ipi-sdn`
ci/prow/e2e-openstack-ovn	`b05b30e`	link	false	`/test e2e-openstack-ovn`
ci/prow/e2e-aws-ovn-etcd-scaling	`b05b30e`	link	false	`/test e2e-aws-ovn-etcd-scaling`
ci/prow/e2e-vsphere-ovn-etcd-scaling	`b05b30e`	link	false	`/test e2e-vsphere-ovn-etcd-scaling`
ci/prow/e2e-aws-ovn-upgrade	`b05b30e`	link	false	`/test e2e-aws-ovn-upgrade`
ci/prow/e2e-aws-ovn-cgroupsv2	`b05b30e`	link	false	`/test e2e-aws-ovn-cgroupsv2`
ci/prow/e2e-aws-ovn-single-node	`b05b30e`	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/e2e-aws-ovn-single-node-upgrade	`b05b30e`	link	false	`/test e2e-aws-ovn-single-node-upgrade`
ci/prow/e2e-azure-ovn-etcd-scaling	`b05b30e`	link	false	`/test e2e-azure-ovn-etcd-scaling`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Elbehery · 2023-02-02T15:15:53Z

/retest-required

Elbehery · 2023-02-04T12:46:00Z

@hasbro17 closing this in favour of #27702

/close

openshift-ci · 2023-02-04T12:46:10Z

@Elbehery: Closed this PR.

Details

In response to this:

@hasbro17 closing this in favour of #27702

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-02-04T12:46:13Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-6841. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #27497

/assign hasbro17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot mentioned this pull request Jan 27, 2023

Update etcd scaling test for CPMS supported platforms #27497

Merged

openshift-cherrypick-robot assigned hasbro17 Jan 27, 2023

openshift-ci bot requested review from csrwng and hasbro17 January 27, 2023 21:54

openshift-ci bot assigned Elbehery Jan 31, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2023

openshift-ci bot changed the title ~~[release-4.12] Update etcd scaling test for CPMS supported platforms~~ [release-4.12] OCPBUGS-6841: Update etcd scaling test for CPMS supported platforms Jan 31, 2023

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 31, 2023

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 31, 2023

openshift-ci bot requested a review from geliu2016 January 31, 2023 14:21

geliu2016 approved these changes Feb 1, 2023

View reviewed changes

Elbehery reviewed Feb 1, 2023

View reviewed changes

openshift-ci bot closed this Feb 4, 2023

	waitPollTimeout := 10 * time.Minute
	waitPollTimeout := 18 * time.Minute

[release-4.12] OCPBUGS-6841: Update etcd scaling test for CPMS supported platforms #27692

[release-4.12] OCPBUGS-6841: Update etcd scaling test for CPMS supported platforms #27692

Uh oh!

Conversation

openshift-cherrypick-robot commented Jan 27, 2023

Uh oh!

Elbehery commented Jan 31, 2023

Uh oh!

Elbehery commented Jan 31, 2023

Uh oh!

Elbehery commented Jan 31, 2023

Uh oh!

openshift-ci-robot commented Jan 31, 2023

Uh oh!

openshift-ci bot commented Jan 31, 2023

Uh oh!

Elbehery commented Jan 31, 2023

Uh oh!

Elbehery commented Jan 31, 2023

Uh oh!

openshift-ci-robot commented Jan 31, 2023

Uh oh!

Elbehery commented Jan 31, 2023

Uh oh!

geliu2016 left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Feb 1, 2023

Uh oh!

openshift-ci bot commented Feb 1, 2023

Uh oh!

hasbro17 commented Feb 1, 2023

Uh oh!

Elbehery commented Feb 1, 2023

Uh oh!

Elbehery Feb 1, 2023

Choose a reason for hiding this comment

Uh oh!

Elbehery Feb 1, 2023

Choose a reason for hiding this comment

Uh oh!

Elbehery commented Feb 2, 2023

Uh oh!

openshift-ci bot commented Feb 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Elbehery commented Feb 2, 2023

Uh oh!

Elbehery commented Feb 4, 2023

Uh oh!

openshift-ci bot commented Feb 4, 2023

Uh oh!

openshift-ci-robot commented Feb 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openshift-ci bot commented Feb 2, 2023 •

edited

Loading