[release-4.12] OCPBUGS-6841: Update the vertical scaling test to account for CPMSO #27907

Elbehery · 2023-05-04T17:07:09Z

This PR is a manual cherrypick of #27788

resolves https://issues.redhat.com/browse/OCPBUGS-6841

openshift-ci · 2023-05-04T17:07:13Z

@Elbehery: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

manual cherrypick of #27788

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Elbehery · 2023-05-04T17:07:23Z

/assign @hasbro17
/assign @tjungblu

openshift-ci · 2023-05-04T17:07:56Z

@Elbehery: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-6841: Update the vertical scaling test to account for CPMSO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-05-04T17:07:59Z

@Elbehery: This pull request references Jira Issue OCPBUGS-6841, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.z) matches configured target version for branch (4.12.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-6844 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-6844 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
bug has dependents

Requesting review from QA contact:
/cc @geliu2016

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR is a manual cherrypick of #27788

resolves https://issues.redhat.com/browse/OCPBUGS-6841

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Elbehery · 2023-05-04T20:55:05Z

/retest

geliu2016

/label cherry-pick-approved

openshift-ci · 2023-05-05T02:47:19Z

@geliu2016: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-staff-engineers]

Details

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-05-05T07:57:11Z

@Elbehery: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

Details

In response to this:

[release-4.12] OCPBUGS-6841: Update the vertical scaling test to account for CPMSO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tjungblu · 2023-05-05T08:01:32Z

/lgtm

Elbehery · 2023-05-05T08:25:55Z

/retest-required

Elbehery · 2023-05-05T08:31:29Z

/label tide/merge-method-squash

Elbehery · 2023-05-05T11:18:26Z

locally make verify

hack/verify-jsonformat.sh
hack/verify-generated.sh
SUCCESS after 47.000s: hack/verify-generated.sh:13: executing '/Users/mustafa/workspace/go/src/openshift/origin/hack/update-generated.sh' expecting success
SUCCESS after 0.000s: hack/verify-generated.sh:14: executing 'git diff --exit-code /Users/mustafa/workspace/go/src/openshift/origin/test/extended/util/annotate/generated/' expecting success
SUCCESS after 1.000s: hack/verify-generated.sh:15: executing 'git diff --exit-code /Users/mustafa/workspace/go/src/openshift/origin/test/extended/util/image/zz_generated.txt' expecting success
[INFO] hack/verify-generated.sh exited with code 0 after 00h 00m 48s

dont know why it fails here

ERRO[2023-05-05T08:57:15Z] 
  * could not run steps: step verify failed: test "verify" failed: could not watch pod: the pod ci-op-75zgjrnz/verify failed after 4m25s (failed containers: test): ContainerFailed one or more containers exited
Container test exited with code 2, reason Error
---
-51457,11 +51457,13 @@ var _bindata = map[string]func() (*asset
 // directory embedded in the file by go-bindata.
 // For example if you run go-bindata on data/... and data contains the
 // following hierarchy:
-//     data/
-//       foo.txt
-//       img/
-//         a.png
-//         b.png
+//
+//	data/
+//	  foo.txt
+//	  img/
+//	    a.png
+//	    b.png
+//
 // then AssetDir("data") would return []string{"foo.txt", "img"}
 // AssetDir("data/img") would return []string{"a.png", "b.png"}
 // AssetDir("foo.txt") and AssetDir("notexist") would return an error
make: *** [Makefile:101: verify-bindata-bindata] Error 1
hack/verify-jsonformat.sh
hack/verify-generated.sh
Running hack/verify-generated.sh:13: executing '/go/src/github.com/openshift/origin/hack/update-generated.sh' expecting success...
SUCCESS after 37.[67](https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/27907/pull-ci-openshift-origin-release-4.12-verify/1654403481483612160#1:build-log.txt%3A67)0s: hack/verify-generated.sh:13: executing '/go/src/github.com/openshift/origin/hack/update-generated.sh' expecting success
Running hack/verify-generated.sh:14: executing 'git diff --exit-code /go/src/github.com/openshift/origin/test/extended/util/annotate/generated/' expecting success...
SUCCESS after 1.4[76](https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/27907/pull-ci-openshift-origin-release-4.12-verify/1654403481483612160#1:build-log.txt%3A76)s: hack/verify-generated.sh:14: executing 'git diff --exit-code /go/src/github.com/openshift/origin/test/extended/util/annotate/generated/' expecting success
Running hack/verify-generated.sh:15: executing 'git diff --exit-code /go/src/github.com/openshift/origin/test/extended/util/image/zz_generated.txt' expecting success...
SUCCESS after 0.034s: hack/verify-generated.sh:15: executing 'git diff --exit-code /go/src/github.com/openshift/origin/test/extended/util/image/zz_generated.txt' expecting success
[INFO] hack/verify-generated.sh exited with code 0 after 00h 00m 39s
make: Target 'verify' not remade because of errors.
{"component":"entrypoint","error":"wrapped process failed: exit status 2","file":"k8s.io/test-infra/prow/entrypoint/run.go:[79](https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/27907/pull-ci-openshift-origin-release-4.12-verify/1654403481483612160#1:build-log.txt%3A79)","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2023-05-05T08:57:14Z"}
--- 
INFO[2023-05-05T08:57:15Z] Reporting job state 'failed' with reason 'executing_graph:step_failed:running_pod'

Elbehery · 2023-05-06T15:23:27Z

running make verify locally

 make verify
Running `gofmt -s -l` on 518 file(s).
go vet -mod=vendor ./...
ln -s /Users/mustafa/workspace/go/src/openshift/origin/vendor "/var/folders/vh/wkbmyt411316pt46h81d6_300000gn/T/tmp.PUz3EMOo/src"
export GO111MODULE=off && export GOPATH=/var/folders/vh/wkbmyt411316pt46h81d6_300000gn/T/tmp.PUz3EMOo && export GOBIN=/var/folders/vh/wkbmyt411316pt46h81d6_300000gn/T/tmp.PUz3EMOo/bin && go install "./vendor/github.com/go-bindata/go-bindata/..."
/var/folders/vh/wkbmyt411316pt46h81d6_300000gn/T/tmp.PUz3EMOo/bin/go-bindata -nocompress -nometadata -prefix "testextended" -pkg "testdata" -o "/var/folders/vh/wkbmyt411316pt46h81d6_300000gn/T/tmp.2ZyrVERe/test/extended/testdata/bindata.go" -ignore "OWNERS" -ignore ".*\.(go|md)$" examples/db-templates examples/image-streams examples/sample-app examples/quickstarts/... examples/hello-openshift examples/jenkins/... examples/quickstarts/cakephp-mysql.json test/extended/testdata/... e2echart && gofmt -s -w "/var/folders/vh/wkbmyt411316pt46h81d6_300000gn/T/tmp.2ZyrVERe/test/extended/testdata/bindata.go" && diff -Naup {.,/var/folders/vh/wkbmyt411316pt46h81d6_300000gn/T/tmp.2ZyrVERe}/test/extended/testdata/bindata.go
hack/verify-jsonformat.sh
hack/verify-generated.sh
SUCCESS after 47.000s: hack/verify-generated.sh:13: executing '/Users/mustafa/workspace/go/src/openshift/origin/hack/update-generated.sh' expecting success
SUCCESS after 0.000s: hack/verify-generated.sh:14: executing 'git diff --exit-code /Users/mustafa/workspace/go/src/openshift/origin/test/extended/util/annotate/generated/' expecting success
SUCCESS after 0.000s: hack/verify-generated.sh:15: executing 'git diff --exit-code /Users/mustafa/workspace/go/src/openshift/origin/test/extended/util/image/zz_generated.txt' expecting success
[INFO] hack/verify-generated.sh exited with code 0 after 00h 00m 47s

Elbehery · 2023-05-08T16:46:40Z

/retest

Elbehery · 2023-05-11T12:36:37Z

failing required jobs are not related to the change

/retest-required

openshift-ci · 2023-05-11T15:07:52Z

@Elbehery: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn-etcd-scaling	`2230ae9`	link	false	`/test e2e-vsphere-ovn-etcd-scaling`
ci/prow/e2e-aws-ovn-single-node-upgrade	`2230ae9`	link	false	`/test e2e-aws-ovn-single-node-upgrade`
ci/prow/e2e-aws-ovn-single-node	`2230ae9`	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/e2e-metal-ipi-serial-ovn-ipv6	`2230ae9`	link	false	`/test e2e-metal-ipi-serial-ovn-ipv6`
ci/prow/e2e-openstack-ovn	`2230ae9`	link	false	`/test e2e-openstack-ovn`
ci/prow/e2e-gcp-ovn-rt-upgrade	`2230ae9`	link	false	`/test e2e-gcp-ovn-rt-upgrade`
ci/prow/e2e-aws-ovn-single-node-serial	`2230ae9`	link	false	`/test e2e-aws-ovn-single-node-serial`
ci/prow/e2e-aws-ovn-upgrade	`2230ae9`	link	false	`/test e2e-aws-ovn-upgrade`
ci/prow/e2e-gcp-ovn-etcd-scaling	`2230ae9`	link	false	`/test e2e-gcp-ovn-etcd-scaling`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Elbehery · 2023-05-15T08:12:48Z

@hasbro17 PTAL needs Not mergeable. Needs approved, backport-risk-assessed labels

hasbro17 · 2023-05-15T23:32:16Z

/approve
/label backport-risk-assessed

openshift-ci · 2023-05-15T23:32:27Z

@hasbro17: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

Details

In response to this:

/approve
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hasbro17 · 2023-05-15T23:32:55Z

/test e2e-aws-ovn-etcd-scaling

Elbehery · 2023-05-23T12:16:04Z

/retest-required

dusk125 · 2023-05-23T15:37:45Z

/lgtm

openshift-ci · 2023-05-23T15:39:41Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: dusk125, Elbehery, geliu2016, hasbro17, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/extended/etcd/OWNERS~~ [hasbro17]
test/extended/util/annotate/generated/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hasbro17 · 2023-05-23T17:01:27Z

@dgoodwin If you could please add the cherry-pick-approved label 🙇

openshift-ci-robot · 2023-05-23T17:46:18Z

@Elbehery: Jira Issue OCPBUGS-6841 is in an unrecognized state (Closed) and will not be moved to the MODIFIED state.

Details

In response to this:

This PR is a manual cherrypick of #27788

resolves https://issues.redhat.com/browse/OCPBUGS-6841

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot assigned hasbro17 and tjungblu May 4, 2023

Elbehery changed the title ~~manual cherrypick of #27788~~ OCPBUGS-6841: Update the vertical scaling test to account for CPMSO May 4, 2023

openshift-ci bot requested review from csrwng, geliu2016 and hasbro17 May 4, 2023 17:08

geliu2016 approved these changes May 5, 2023

View reviewed changes

manual cherrypick of openshift#27788

71b7f00

Elbehery force-pushed the cherry-pick-27788-to-release-4.12 branch from 8149c28 to 71b7f00 Compare May 5, 2023 07:48

Elbehery changed the title ~~OCPBUGS-6841: Update the vertical scaling test to account for CPMSO~~ [release-4.12] OCPBUGS-6841: Update the vertical scaling test to account for CPMSO May 5, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2023

Elbehery mentioned this pull request May 5, 2023

[release-4.12] OCPBUGS-6841: Update etcd scaling test for CPMS supported platforms #27702

Closed

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 5, 2023

openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 5, 2023

Elbehery force-pushed the cherry-pick-27788-to-release-4.12 branch from 8ffabf4 to be24f79 Compare May 5, 2023 16:26

bindata diff

3ada165

Elbehery force-pushed the cherry-pick-27788-to-release-4.12 branch from 740c40e to 3ada165 Compare May 10, 2023 16:22

go1.19 diff

2230ae9

deads2k added approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels May 23, 2023

openshift-ci bot assigned dgoodwin, gangwgr, jadhaj, jitendar-singh, kasturinarra, pamoedom, prietyc123 and stbenjam May 23, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2023

deads2k added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 23, 2023

openshift-merge-robot merged commit 06127b0 into openshift:release-4.12 May 23, 2023

Elbehery deleted the cherry-pick-27788-to-release-4.12 branch September 30, 2024 03:47

[release-4.12] OCPBUGS-6841: Update the vertical scaling test to account for CPMSO #27907

[release-4.12] OCPBUGS-6841: Update the vertical scaling test to account for CPMSO #27907

Uh oh!

Conversation

Elbehery commented May 4, 2023

Uh oh!

openshift-ci bot commented May 4, 2023

Uh oh!

Elbehery commented May 4, 2023

Uh oh!

openshift-ci bot commented May 4, 2023

Uh oh!

openshift-ci-robot commented May 4, 2023

Uh oh!

Elbehery commented May 4, 2023

Uh oh!

geliu2016 left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented May 5, 2023

Uh oh!

openshift-ci bot commented May 5, 2023

Uh oh!

tjungblu commented May 5, 2023

Uh oh!

Elbehery commented May 5, 2023

Uh oh!

Elbehery commented May 5, 2023

Uh oh!

Elbehery commented May 5, 2023

Uh oh!

Elbehery commented May 6, 2023

Uh oh!

Elbehery commented May 8, 2023

Uh oh!

Elbehery commented May 11, 2023

Uh oh!

openshift-ci bot commented May 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Elbehery commented May 15, 2023

Uh oh!

hasbro17 commented May 15, 2023

Uh oh!

openshift-ci bot commented May 15, 2023

Uh oh!

hasbro17 commented May 15, 2023

Uh oh!

Elbehery commented May 23, 2023

Uh oh!

dusk125 commented May 23, 2023

Uh oh!

openshift-ci bot commented May 23, 2023

Uh oh!

hasbro17 commented May 23, 2023

Uh oh!

openshift-ci-robot commented May 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

openshift-ci bot commented May 11, 2023 •

edited

Loading