add event interval from rest client metric broken down by source#27976
add event interval from rest client metric broken down by source#27976tkashem wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tkashem The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
||
| func (g *gatherer) query(ctx context.Context) (prometheustypes.Value, error) { | ||
| // TODO: should we include 5xx? "429|5..|<error>" | ||
| query := `rest_client_requests_total{code =~ "429|5..|<error>"}` |
There was a problem hiding this comment.
I wonder if we can add DNS resolve error - or it won't be recorded?
There was a problem hiding this comment.
yes, when Michal's upstream PR merges, we can incorporate it.
There was a problem hiding this comment.
to be more clear, if dns error happens code=<error>, any other network error, code=<error> also. (we can't make the distinction today with rest_client_requests_total. Michal's PR adds a new metric just to capture dns error.
|
The upstream PR: kubernetes/kubernetes#115357 |
tkashem
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
tkashem
force-pushed
the
client-view
branch
2 times, most recently
from
3ea8c6a to
e7cc6c2
Compare
|
/retest-required |
|
@tkashem: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
|
@p0lyn0mial @dgrisonnet Would like to have your inputs on this PR. Abu indicates this PR is ready for merge. We can either merge it and I can create subsequent PRs to address feedbacks or incorporate those changes into linked Vadim's PR. |
|
I think we should close this one and wrap up the work on the PR Vadim opened and improved. |
Sounds fair. Let do that. |
|
/close |
|
@vrutkovs: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
No description provided.