Skip to content

OCPVE-723: Add optional olm fixes#28302

Merged
openshift-ci[bot] merged 3 commits intoopenshift:masterfrom
eggfoobar:add-optional-olm-fixes
Oct 14, 2023
Merged

OCPVE-723: Add optional olm fixes#28302
openshift-ci[bot] merged 3 commits intoopenshift:masterfrom
eggfoobar:add-optional-olm-fixes

Conversation

@eggfoobar
Copy link
Copy Markdown
Contributor

Add Support for optional OLM capability

  • Add Skip annotation for OLM tests since OLM will not be running in a cluster that has capabilities set to None
  • Bumped API to pull in new API change
  • Moved OLM CRDs to conditionally add them when OLM is enabled

/hold
Holding for validation

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 6, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 6, 2023

@eggfoobar: This pull request references OCPVE-723 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Add Support for optional OLM capability

  • Add Skip annotation for OLM tests since OLM will not be running in a cluster that has capabilities set to None
  • Bumped API to pull in new API change
  • Moved OLM CRDs to conditionally add them when OLM is enabled

/hold
Holding for validation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2023
@openshift-ci openshift-ci Bot requested review from deads2k and dtantsur October 6, 2023 00:18
@openshift-ci openshift-ci Bot added the vendor-update Touching vendor dir or related files label Oct 6, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 6, 2023

@eggfoobar: This pull request references OCPVE-723 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Add Support for optional OLM capability

  • Add Skip annotation for OLM tests since OLM will not be running in a cluster that has capabilities set to None
  • Bumped API to pull in new API change
  • Moved OLM CRDs to conditionally add them when OLM is enabled

/hold
Holding for validation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eggfoobar
Copy link
Copy Markdown
Contributor Author

/assign @kevinrizza

Hey @kevinrizza This should be good to review, We're skipping tests for OLM, is the [sig-operator] always for OLM or should I make that more narrow?

Signed-off-by: ehila <ehila@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar
Copy link
Copy Markdown
Contributor Author

/unhold

@kevinrizza This should be good for final review, was able to verify no more OLM errors during no-cap CI runs. https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-launch-aws-modern/1712923427997749248

Note: the CRD Builds errors can be ignored, since they are not related to OLM and a fix will be coming shortly for them.

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2023
@bparees
Copy link
Copy Markdown
Contributor

bparees commented Oct 13, 2023

/approve
/lgtm

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 13, 2023
@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD d75ad27 and 2 for PR HEAD 202ba3f in total

@eggfoobar
Copy link
Copy Markdown
Contributor Author

/retest-required

@kevinrizza
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, eggfoobar, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eggfoobar
Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 14, 2023

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial 202ba3f link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-openstack-ovn 202ba3f link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-upgrade 202ba3f link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 202ba3f link false /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot merged commit 1b8e400 into openshift:master Oct 14, 2023
@eggfoobar eggfoobar deleted the add-optional-olm-fixes branch October 14, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants