MCO-1523: PinnedImageSet v1alpha1 Testing#29599
Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom Apr 10, 2025
Merged
MCO-1523: PinnedImageSet v1alpha1 Testing#29599openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
RishabhSaini
force-pushed
the
pis
branch
5 times, most recently
from
f988273 to
35d4a21
Compare
|
Job Failure Risk Analysis for sha: 35d4a21
|
RishabhSaini
force-pushed
the
pis
branch
5 times, most recently
from
c2d25fe to
70ffa86
Compare
|
Job Failure Risk Analysis for sha: 70ffa86
Showing 20 of 44 jobs analysis Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 70ffa86
New tests seen in this PR at sha: 70ffa86
|
RishabhSaini
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@RishabhSaini: This pull request references MCO-1523 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
djoshy
reviewed
Mar 19, 2025
Contributor
djoshy
left a comment
djoshy
left a comment
There was a problem hiding this comment.
General test flow looks good to me - just a few nits. Nice work!
| "sigs.k8s.io/yaml" | ||
| ) | ||
|
|
||
| // This test is [Serial] because it modifies the cluster/machineconfigurations.operator.openshift.io object in each test. |
Contributor
There was a problem hiding this comment.
Comment doesn't match up here 😄 Also, serial/parallel maybe something to consider if you think these tests could be run in parallel.
Contributor
Author
There was a problem hiding this comment.
updated. I will holdoff running it in parallel till I can get a single clean run in CI
Contributor
|
I'll defer to @hexfusion for the final tag, I'm happy with the current state. I don't see a tech preview variant in the default run presubmits, let's see if there's any we can call. /test ? |
Contributor
|
@djoshy: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
/test e2e-gcp-ovn-techpreview |
Contributor
|
/test e2e-gcp-ovn-techpreview-serial |
Contributor
Author
|
/test e2e-gcp-ovn-techpreview e2e-aws-ovn-single-node-techpreview-serial e2e-gcp-ovn-techpreview-serial |
Contributor
Author
|
/test e2e-aws-ovn-single-node-techpreview-serial e2e-aws-ovn-techpreview-serial |
Contributor
Author
|
/test e2e-gcp-ovn-techpreview e2e-gcp-ovn-techpreview-serial |
|
Job Failure Risk Analysis for sha: ed99368
|
|
Job Failure Risk Analysis for sha: ca7d47a
|
|
Job Failure Risk Analysis for sha: ca7d47a
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: ca7d47a
New tests seen in this PR at sha: ca7d47a
|
Contributor
Author
|
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial |
Contributor
|
@RishabhSaini: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/506b5990-14a4-11f0-8a70-ac7a402cccfa-0 |
Contributor
Author
|
/test e2e-aws-ovn-single-node-techpreview-serial e2e-gcp-ovn-techpreview-serial |
|
Job Failure Risk Analysis for sha: 55259e7
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 55259e7
New tests seen in this PR at sha: 55259e7
|
|
Job Failure Risk Analysis for sha: 55259e7
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 55259e7
New tests seen in this PR at sha: 55259e7
|
Contributor
Author
|
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial |
Contributor
|
@RishabhSaini: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/22fa1680-14fa-11f0-9f72-e5c4e21b653e-0 |
Contributor
Author
|
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial |
Contributor
|
@RishabhSaini: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/859a85d0-1532-11f0-8c7a-3491c1517acc-0 |
Contributor
Author
|
/retest-required |
Contributor
Author
|
/test e2e-gcp-ovn-techpreview-serial |
Contributor
Author
|
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial |
Contributor
|
@RishabhSaini: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/aaa4fe90-1542-11f0-8fc3-4fc9a650e69b-0 |
Contributor
Author
|
/test e2e-gcp-ovn-techpreview-serial |
1 similar comment
Contributor
Author
|
/test e2e-gcp-ovn-techpreview-serial |
Contributor
Author
|
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial |
Contributor
|
@RishabhSaini: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e1e67a60-155f-11f0-9016-b943c511d64e-0 |
|
Job Failure Risk Analysis for sha: ed04599
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: ed04599
New tests seen in this PR at sha: ed04599
|
Contributor
|
/lgtm test results look good, thanks for the fixups! |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DennisPeriquet, djoshy, hexfusion, RishabhSaini The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest-required |
Contributor
|
@RishabhSaini: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
Bot
merged commit 6c336d1
into
openshift:main
33 of 55 checks passed
Contributor
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.