Skip to content

MCO-1599: MCN impersonation tests#29619

Closed
pablintino wants to merge 3 commits intoopenshift:mainfrom
pablintino:mcn-impersonation-tests
Closed

MCO-1599: MCN impersonation tests#29619
pablintino wants to merge 3 commits intoopenshift:mainfrom
pablintino:mcn-impersonation-tests

Conversation

@pablintino
Copy link
Copy Markdown
Contributor

This commits ports from the MCO repo the scope and impersonation tests already existing for the MCN feature.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 21, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 21, 2025

@pablintino: This pull request references MCO-1599 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

This commits ports from the MCO repo the scope and impersonation tests already existing for the MCN feature.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 21, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pablintino
Once this PR has been reviewed and has the lgtm label, please assign stbenjam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pablintino pablintino force-pushed the mcn-impersonation-tests branch from 76b695c to e31e45c Compare March 24, 2025 13:10
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2025
@pablintino pablintino force-pushed the mcn-impersonation-tests branch from e31e45c to adec64f Compare April 2, 2025 16:31
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2025
@pablintino pablintino force-pushed the mcn-impersonation-tests branch from adec64f to cdebe7f Compare April 2, 2025 16:35
This commits ports from the MCO repo the scope and impersonation tests
already existing for the MCN feature.
@pablintino pablintino force-pushed the mcn-impersonation-tests branch from cdebe7f to 8bd781e Compare April 2, 2025 16:45
@isabella-janssen
Copy link
Copy Markdown
Member

isabella-janssen commented Apr 2, 2025

The tests for MCO-1599 lgtm.

@djoshy since you wrote the original tests in the MCO repo for this, would you be able to take a look also?

@isabella-janssen
Copy link
Copy Markdown
Member

/close

These tests were pulled into #29596, so this PR is no longer needed.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2025
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot closed this Apr 10, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 10, 2025

@isabella-janssen: Closed this PR.

Details

In response to this:

/close

These tests were pulled into #29596, so this PR is no longer needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants