MCO-1631: Remove "[sig-arch][Early] CRDs for openshift.io should have a status in the CRD schema"#29643
Conversation
|
/retest |
| "imagecontentpolicies.config.openshift.io", | ||
| "imagecontentsourcepolicies.operator.openshift.io", | ||
| "machineconfigs.machineconfiguration.openshift.io", | ||
| "pinnedimagesets.machineconfiguration.openshift.io", |
There was a problem hiding this comment.
/hold
don't do this. You could add checking to ensure that if no status subresource exists it's only ok if no status exists, but this opens up to severe errors around permissioning and semantics we cannot fix.
There was a problem hiding this comment.
the original goal of the testing was
they aren't required to have status. Some objects don't. But if they have status in the schema, they must have a status subresource
if the implementation got confused, that can be resolved. But if a status subelement exists, it must have a subresource for it.
openshift-ci
Bot
added
the
do-not-merge/hold
|
Discussed in slack and going into past history found that this test was an unneeded side quest: #26954 (comment) . Rather than exception, remove the entire test requiring a status stanza in the schema. We must keep the test that ensures every CRD with a status stanza also has a status subresource and no new exceptions should appear there. /hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
RishabhSaini
force-pushed
the
exceptionPIS
branch
from
b30608d to
f4a2ff8
Compare
RishabhSaini
changed the title
everettraven
left a comment
everettraven
left a comment
There was a problem hiding this comment.
LGTM based on the discussion with @deads2k in slack: https://redhat-internal.slack.com/archives/CE4L0F143/p1743606075623449
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, everettraven, RishabhSaini The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
RishabhSaini
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@RishabhSaini: This pull request references MCO-1631 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
Bot
merged commit f8b7258
into
openshift:main
|
@RishabhSaini: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
5 participants
"[sig-arch][Early] CRDs for openshift.io should have a status in the CRD schema" is no longer relevant.
We only want to be checking for:
If a CRD has a "status" field in the schema but no subresource.status defined. (which causes several problems). Its covered by an existing test "[sig-arch][Early] CRDs for openshift.io should have subresource.status". Hence leaving no need for the prior test to exist.
This work blocks openshift/api#2257, which is necessary to ship PIS as a feature for 4.19