NO-JIRA: We should always run tests where we have no opinion on their gate #29828
Conversation
JoelSpeed
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@JoelSpeed: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
CC @stbenjam |
|
/retest-required |
|
/payload 4.19 nightly blocking |
|
@stbenjam: trigger 11 job(s) of type blocking for the nightly release of OCP 4.19
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9a9a3730-4220-11f0-96f2-b19db0adfc1b-0 |
|
/payload-abort |
|
/payload 4.20 nightly blocking |
|
@stbenjam: trigger 11 job(s) of type blocking for the nightly release of OCP 4.20
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b150bad0-4220-11f0-8332-024f4c65541c-0 |
|
/payload 4.20 nightly blocking |
|
@JoelSpeed: trigger 11 job(s) of type blocking for the nightly release of OCP 4.20
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/155ef1a0-45e0-11f0-9381-746e51c5ad0c-0 |
|
/payload 4.20 nightly blocking |
|
@JoelSpeed: trigger 11 job(s) of type blocking for the nightly release of OCP 4.20
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1afe36b0-4a8c-11f0-89cc-cff19ee88b59-0 |
|
I've reviewed the output of the payload jobs this morning and checked the JUnit from several of the jobs. As far as i can tell this is still enabling the same set of jobs. I found some discrepancies between the JUnits but these can be attributed to the fact that a number of the I'm confident in this PR and believe we should move forward. /retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
1 similar comment
|
/retest-required |
|
/retest-required |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/skip |
|
/hold Revision 89e5a3a was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Job Failure Risk Analysis for sha: 89e5a3a
|
|
Job Failure Risk Analysis for sha: 89e5a3a
|
|
Job Failure Risk Analysis for sha: 89e5a3a
|
|
Job Failure Risk Analysis for sha: 89e5a3a
|
|
Job Failure Risk Analysis for sha: 89e5a3a
|
|
@JoelSpeed: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 89e5a3a
|
1 similar comment
|
Job Failure Risk Analysis for sha: 89e5a3a
|
|
/retest-required |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
4 participants
When a test is added, that contains
[OCPFeatureGate:, we expect that the gate already exists in openshift/api and we therefore have an opinion about the gate as to whether it is enabled or disabled.In all cases, we render every known gate as either enabled or disabled, so every gate has an opinion.
However, when we remove gates, we no longer have an opinion, and the current code disables the tests.
Generally, removing the gate means the feature was promoted to default in a previous release, and therefore the tests should continue to run.
In some cases, the gate may be removed without ever graduating. This is rare, and in these cases we would start running their tests with the feature removed, which would fail, and we would find out pretty quickly.
This seems like the lesser of two evils, the alternative is we just stop running tests and are oblivious to this