OCPBUGS-65826: test/e2e/upgrade: ensure ClusterOperators test always produces a result #30509
Conversation
The ClusterOperators test was defined as a deferred function inside the clusterUpgrade function, which meant it would not run if the parent test "Cluster should remain functional during upgrade" failed before calling clusterUpgrade (e.g., during config loading or upgrade context setup). Move the deferred test to the parent test scope so it always runs and produces a result, even when earlier tests fail. Also remove the duplicate non-deferred version that only ran on success. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment |
openshift-ci-robot
added
jira/valid-reference
|
@stbenjam: This pull request references Jira Issue OCPBUGS-65826, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
… from always passing This test was previously excluded from aggregation because it would fail alongside other results, so we didn't need to aggregate this one (I think that was the reasoning). https://prow.ci.openshift.org/view/gs/test-platform-results/logs/aggregated-aws-ovn-upgrade-4.21-micro-fips-release-openshift-release-analysis-aggregator/1991442012515078144 is an example where it failed 8x alone and we didn't aggregate it. The only reason we caught the problem was openshift/origin#30509, the ClusterOperators test does not always run so we failed on missing results, rather than the actual failing test.
| f, | ||
| "[sig-cluster-lifecycle] ClusterOperators are available and not degraded after upgrade", | ||
| func() (error, bool) { | ||
| if err := operator.WaitForOperatorsToSettle(context.TODO(), client, 5); err != nil { |
There was a problem hiding this comment.
Does this just waste 5 minutes spinning now when the upgrade wasn't successful?
|
Scheduling required tests: Scheduling tests matching the |
|
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@stbenjam: This pull request references Jira Issue OCPBUGS-65826. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3 participants
The ClusterOperators test was defined as a deferred function inside the clusterUpgrade function, which meant it would not run if the parent test "Cluster should remain functional during upgrade" failed before calling clusterUpgrade (e.g., during config loading or upgrade context setup).
Move the deferred test to the parent test scope so it always runs and produces a result, even when earlier tests fail. Also remove the duplicate non-deferred version that only ran on success.
🤖 Generated with Claude Code
/hold