Add empty state help for projects page

[spadgett]

Adds some help text when you first login to OpenShift and have no projects.

[spadgett]

@jwforres @smarterclayton @liggitt @ajacobs21e what do you think?

Here is an empty project for reference. We might change that message because we're repeating ourselves.

[spadgett]

I wanted to add an OpenShift logo beside the "Welcome to OpenShift" header, but I couldn't find one that worked on a gray background.

[jwforres]

Couple comments:

• in v3 we dont refer to them as QuickStarts, we have been calling them instant apps
• don't say "community" documentation since this will be in enterprise as well and enterprise would link to the enterprise docs
• I think we should still have the same type of help when you can't create projects, just change the "create a project" references as needed to say request a project or something

@sg00dwin see sam's comment about wanting an openshift logo #4317 (comment)

[spadgett]

We should probably open a doc defect since it uses the term QuickStart:

https://docs.openshift.org/latest/admin_guide/install/first_steps.html#creating-quickstart-templates

[liggitt]

careful with logos or community references... those all need to be swappable in alternate releases

[liggitt]

remember, newProjectMessage can contain the customized message from the admin. They might have enabled a way for users to create projects for themselves, so we have to show it if it exists (using linky), and we shouldn't pair it with an "Unfortunately..." header

[jwforres]

Ok I wasn't aware of that, I guess we started calling them QuickStarts
again? @smarterclayton ? @bparees?

On Fri, Aug 21, 2015 at 2:42 PM, Sam Padgett notifications@github.com
wrote:

We should probably open a doc defect since it uses the term QuickStart:

https://docs.openshift.org/latest/admin_guide/install/first_steps.html#creating-quickstart-templates

—
Reply to this email directly or view it on GitHub
#4317 (comment).

[bparees]

@jwforres i'm not sure we ever did a great job of picking one or the other.

v2 quickstart: a way to get multiple cartridges created at once.
v2 instant-app: a way to get an app created from a specific source repo. may also include multiple cartridges, so arguably an enhanced quickstart

v3 template: can serve in the role of either a quickstart or an instant-app (might provide a default source-uri to a useful app, or might expect you to provide a source-uri because it's just a generic helper for building java apps with a database)

but i'm ok with changing the docs to s/QuickStart/InstantApp/ if that's what we want.

[smarterclayton]

I'm not in love with the white box. I would prefer something more subtle. To many overlapping rectangles.

[jwforres]

which white box... the one on the empty project list is exactly what we do
in v2. Are you talking about the one after you are in a project and the
project is empty?

On Fri, Aug 21, 2015 at 3:03 PM, Clayton Coleman notifications@github.com
wrote:

I'm not in love with the white box. I would prefer something more subtle.
To many overlapping rectangles.

—
Reply to this email directly or view it on GitHub
#4317 (comment).

[smarterclayton]

Yes, project is empty. Basically when it's white left nav and white top bar, then gray, then white box, it looks out of balance. I think empty should look empty.

[liggitt]

I like it. Empty grey feels sad. Sad is bad.

[smarterclayton]

In that first image though, what does it look like when you don't have the white box on the empty projects page? Flush left alignment with no box border.

[smarterclayton]

Or instead of the centered box, do the full width page white bar (like what we have on the homepage and other pages).

[spadgett]

Updated for the comments from @jwforres and @liggitt. Using Instant App for now, but I can change it back.

@smarterclayton working on some screens of your suggestions

[spadgett]

@smarterclayton Gray background. Maybe too many different fonts.

[liggitt]

the big link feels unbalanced... it looks as big as the header. Should it be in the "Create a project" portion of the outline?

[smarterclayton]

That's a lot of fonts.

[spadgett]

White edge to edge background.

I can remove some of the fonts.

[spadgett]

Fewer fonts:

[smarterclayton]

The center content would look better with two columns - sentences that wrap the page are unreadable for most humans. This really needs to be a flow from 1 to 2a and 2b - I would organize them visually that way.

[smarterclayton]

Or even make the right column for the center be a picture so it's narrower text. And cut out some of the text.

[spadgett]

Yeah, typically we add generous margins for wide screen widths, although my hack to try edge to edge white removed them. I think the columns are a good ideas, but I'd probably need to stack them on mobile.

[smarterclayton]

Stack for sure - a picture would be better even.

On Fri, Aug 21, 2015 at 3:55 PM, Sam Padgett notifications@github.com
wrote:

Yeah, typically we add generous margins for wide screen widths, although
my hack to try edge to edge white removed them. I think the columns are a
good ideas, but I'd probably need to stack them on mobile.

—
Reply to this email directly or view it on GitHub
#4317 (comment).

Clayton Coleman | Lead Engineer, OpenShift

[spadgett]

@smarterclayton I wouldn't use this image, but is this what you had in mind?

[smarterclayton]

Yes

[smarterclayton]

Bonus points for having a graphic with arrows that shows source code going into a box and then the box being sent out on a conveyor line (or carried by helicopters into a cloud)

[jwforres]

cc @sg00dwin

[spadgett]

The problem with the edge-to-edge white is the long lines... It looks strange with wide margins (see screenshot). I think it'll still be a problem even with an image unless it's very large.

[spadgett]

[spadgett]

@jwforres Pushed the icon changes to create.html and fixed the icon widths. PTAL

[jwforres]

[merge]

[openshift-bot]

[Test]ing while waiting on the merge queue

[smarterclayton]

That merge looked like it had some angst behind it :)

On Tue, Aug 25, 2015 at 3:37 PM, Jessica Forrester <notifications@github.com

wrote:

[merge]

—
Reply to this email directly or view it on GitHub
#4317 (comment).

Clayton Coleman | Lead Engineer, OpenShift

[jwforres]

Test flake [merge]

[liggitt]

for posterity:

1)  authenticated e2e-user when creating a new project should successfully create a new project
  - Expected false to be true.
      at /data/src/github.com/openshift/origin/assets/test/e2e/test.js:303:91

[spadgett]

Expected false to be true.

Words to meditate on.

[liggitt]

Get used to disappointment

[smarterclayton]

Expected false to be FILENOTFOUND

On Wed, Aug 26, 2015 at 11:59 AM, Jordan Liggitt notifications@github.com
wrote:

Get used to disappointment

—
Reply to this email directly or view it on GitHub
#4317 (comment).

Clayton Coleman | Lead Engineer, OpenShift

[jwforres]

@spadgett the test case failure is because you are hiding the project h1 now when the project is empty

https://github.com/openshift/origin/blob/master/assets/test/e2e/test.js#L303

[spadgett]

@jwforres Thanks, I removed that line since the h1 is no longer there. I'm not sure if goToAddToProjectPage will fail because we added the icons.

[test]

[jwforres]

Hmm instead of removing it can you change it to check for the project name
in the project selector dropdown?

On Wed, Aug 26, 2015 at 12:58 PM, Sam Padgett notifications@github.com
wrote:

@jwforres https://github.com/jwforres Thanks, I removed that line since
the h1 is no longer there. I'm not sure if goToAddToProjectPage will fail
because we added the icons.

[test]

—
Reply to this email directly or view it on GitHub
#4317 (comment).

[spadgett]

@jwforres I can give it a shot, but the e2e tests don't run reliably for me in Vagrant. Is this the right command?

TEST_ASSETS=true TEST_ASSETS_HEADLESS=true hack/test-end-to-end.sh

Is there a way to run just the UI tests?

[jwforres]

On Wed, Aug 26, 2015 at 2:03 PM, Sam Padgett notifications@github.com
wrote:

@jwforres https://github.com/jwforres I can give it a shot, but the e2e
tests don't run reliably for me in Vagrant. Is this the right command?

TEST_ASSETS=true TEST_ASSETS_HEADLESS=true hack/test-end-to-end.sh

Yes. Although I don't know if the latest vbox has been updated to include
chrome. Have you tried launching an ec2 instance instead, syncing your
source and then running the tests? Its a bit slow rebuilding everything,
but should work.

Is there a way to run just the UI tests?

Unfortunately not today @liggitt started to look at whether it would be
possible. Right now the other end to end tests are populating the empty
state of the project for the first test.

—
Reply to this email directly or view it on GitHub
#4317 (comment).

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/4571/)

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3139/) (Image: devenv-fedora_2239)

[spadgett]

[test]

[openshift-bot]

Evaluated for origin test up to 2055720

[spadgett]

@jwforres I updated the test. Please take a look.

[jwforres]

[merge]

[openshift-bot]

Evaluated for origin merge up to 2055720