Skip to content

Reorganize web console create flow#4684

Merged
openshift-bot merged 1 commit intoopenshift:masterfrom
spadgett:create-flow-changes
Sep 25, 2015
Merged

Reorganize web console create flow#4684
openshift-bot merged 1 commit intoopenshift:masterfrom
spadgett:create-flow-changes

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Sep 15, 2015

Present builder images and templates in one catalog grouped by tag.

  • Update catalog layout
  • Show helpful message on empty catalog
  • Add show more link when category has many entries
  • Make tag check case insensitive
  • Filter by keyword and tag
  • Make tag text in tiles clickable filters
  • Use sample repo for selected builder
  • Autofocus name field on create from image page
  • Change imageRepo var names to imageStream
  • Update empty project message for new create options
  • Go directly to create page after adding a new project
  • Move most items into advanced options section to create from image page
  • Search for keywords in description
  • Add back git ref URL fragment
  • Look for sample git ref and context dir annotations
  • Fix tag styles for image stream page
  • Fix problem with mixed case tags
  • Update placeholder text in create form
  • https://bugzilla.redhat.com/show_bug.cgi?id=1266390
  • https://bugzilla.redhat.com/show_bug.cgi?id=1266377

Fixes #4331

@spadgett
Copy link
Member Author

spadgett commented Sep 15, 2015

Create from image page updates, using the sample repos from #4619.

openshift_web_console

@jwforres

@spadgett
Copy link
Member Author

spadgett commented Sep 16, 2015

Empty state message. @jwforres @ajacobs21e opinions?

openshift_web_console

@spadgett
Copy link
Member Author

spadgett commented Sep 16, 2015

@ajacobs21e is there a standard style or icon for back links?

@spadgett spadgett changed the title [WIP] Create flow changes [WIP] Reorganize web console create flow Sep 16, 2015
@ajacobs21e
Copy link

ajacobs21e commented Sep 16, 2015

@spadgett where does the back link go? To overview? Would it make more sense to say "Back to project overview" instead? The link style is right.

The messaging looks good. I would remove the comma after "run the command" or use a colon instead.

@spadgett
Copy link
Member Author

spadgett commented Sep 16, 2015

Thanks, @ajacobs21e. I made your suggested changes.

@jwforres
Copy link
Member

jwforres commented Sep 16, 2015

@spadgett also keep in mind really soon that we are going to let you upload your own template to use from this page. so this message will probably change a bit

cc @gruiz17

@spadgett spadgett force-pushed the create-flow-changes branch 2 times, most recently from 0f1753d to ea35adc Compare September 16, 2015 18:08
@spadgett
Copy link
Member Author

spadgett commented Sep 16, 2015

Added filtering by keyword.

openshift_web_console

@ajacobs21e
Copy link

ajacobs21e commented Sep 16, 2015

+1

On Wed, Sep 16, 2015 at 2:12 PM, Sam Padgett notifications@github.com
wrote:

Added filtering by keyword.

[image: openshift_web_console]
https://cloud.githubusercontent.com/assets/1167259/9913865/f45a8d90-5c7c-11e5-8c9a-d7ab34569844.png

—
Reply to this email directly or view it on GitHub
#4684 (comment).

Allie Jacobs
UXD

calendar
https://www.google.com/calendar/b/1/embed?src=ajacobs@redhat.com&ctz=America/New_York

@spadgett
Copy link
Member Author

spadgett commented Sep 16, 2015

@jwforres Change the description to a tooltip like v2? So little fits on the page. Even switching to 2 columns, you'd only see 6 in this screenshot.

openshift_web_console_and_rails-postgresql_json____go_src_github_com_openshift_origin_tmp_files_examples_quickstart-templates__-vim_and_more_template_changes-spadgett_redhat_com-_red_hat_mail

@spadgett spadgett force-pushed the create-flow-changes branch 3 times, most recently from 223764f to 4b922b2 Compare September 16, 2015 20:14
@spadgett
Copy link
Member Author

spadgett commented Sep 16, 2015

Without descriptions... @sg00dwin is looking at keeping a group in one column like v2.

screen shot 2015-09-16 at 4 14 54 pm

@ajacobs21e
Copy link

ajacobs21e commented Sep 16, 2015

When you select one does it still open a modal or go directly to the next
step?

On Wed, Sep 16, 2015 at 4:16 PM, Sam Padgett notifications@github.com
wrote:

Without descriptions... @sg00dwin https://github.com/sg00dwin is
looking at keeping a group in one column like v2.

[image: screen shot 2015-09-16 at 4 14 54 pm]
https://cloud.githubusercontent.com/assets/1167259/9917175/2b4663a4-5c8e-11e5-88fe-83dc720607f9.png

—
Reply to this email directly or view it on GitHub
#4684 (comment).

Allie Jacobs
UXD

calendar
https://www.google.com/calendar/b/1/embed?src=ajacobs@redhat.com&ctz=America/New_York

@spadgett
Copy link
Member Author

spadgett commented Sep 16, 2015

It goes to the next step, but the description is in the next step and it's easy to go back. It's also in a tooltip.

@jwforres
Copy link
Member

jwforres commented Sep 16, 2015

Maybe we should use a bootstrap popover instead of browser title text? That
way the tooltip is immediate on hover? Browser title hovers aren't the
most discoverable things ever :)

On Wed, Sep 16, 2015 at 4:21 PM, Sam Padgett notifications@github.com
wrote:

It goes to the next step, but the description is in the next step and it's
easy to go back. It's also in a tooltip.

—
Reply to this email directly or view it on GitHub
#4684 (comment).

@spadgett
Copy link
Member Author

spadgett commented Sep 16, 2015

I think that would be better. I'm not sure if the bootstrap popovers work with angular expressions, though.

@spadgett
Copy link
Member Author

spadgett commented Sep 16, 2015

I assume the hover target would be an icon and not the whole tile?

@jwforres
Copy link
Member

jwforres commented Sep 16, 2015

See the pod-warnings directive for a dynamic popover example. Also, we may
want to have the popover be from a ? icon if we find the popovers are
getting in the way of clicking on other tiles.

On Wed, Sep 16, 2015 at 4:29 PM, Sam Padgett notifications@github.com
wrote:

I think that would be better. I'm not sure if the bootstrap popovers work
with angular expressions, though.

—
Reply to this email directly or view it on GitHub
#4684 (comment).

@spadgett spadgett force-pushed the create-flow-changes branch 2 times, most recently from bb1a650 to 4559df9 Compare September 17, 2015 11:01
@jwforres
Copy link
Member

jwforres commented Sep 23, 2015

@spadgett the annotation names are here #4619 (comment)

@spadgett
Copy link
Member Author

spadgett commented Sep 23, 2015

I kept one try it link that fills in everything.

openshift_web_console

@spadgett
Copy link
Member Author

spadgett commented Sep 23, 2015

@jwforres I think that's everything so far.

@liggitt
Copy link
Contributor

liggitt commented Sep 23, 2015

placeholder "master" for the git reference, and "/" for the context dir?

@spadgett
Copy link
Member Author

spadgett commented Sep 23, 2015

Added. Is it strange to use default values for some placeholders and help text for others? I'm not sure "Repository URL" is helpful.

openshift_web_console

@spadgett
Copy link
Member Author

spadgett commented Sep 23, 2015

Without repository URL placeholder:

openshift_web_console

@jwforres
Copy link
Member

jwforres commented Sep 23, 2015

@spadgett yeah agree the repository URL placeholder was a bit redundant

@spadgett
Copy link
Member Author

spadgett commented Sep 23, 2015

yeah agree the repository URL placeholder was a bit redundant

Removed.

@spadgett
Copy link
Member Author

spadgett commented Sep 23, 2015

https://ci.openshift.redhat.com/jenkins/job/fork_ami/89/

@nak3 nak3 mentioned this pull request Sep 25, 2015
Closed
@nak3
Copy link
Contributor

nak3 commented Sep 25, 2015

Is it impossible to create new-app without imagestream/template import?
For example, in case that I would like to create new-app by this style via webconsole:
oc new-app someimage~http://somephprepo --strategy=source

@jwforres
Copy link
Member

jwforres commented Sep 25, 2015

Currently, here is the trello card tracking that
https://trello.com/c/fonu3qc5

On Thu, Sep 24, 2015 at 10:22 PM, Kenjiro Nakayama <notifications@github.com

wrote:

Is it impossible to create new-app without imagestream/template import?
For example, in case that I would like to create new-app by this style via
webconsole:
oc new-app someimage~http://somephprepo --strategy=source

—
Reply to this email directly or view it on GitHub
#4684 (comment).

@nak3
Copy link
Contributor

nak3 commented Sep 25, 2015

Thank you! It will not contain this PR, but it seems that it will implement soon (via another PR(?)). That's great.

@jwforres
Copy link
Member

jwforres commented Sep 25, 2015

Right, it won't be in this PR. I'm not sure how soon we'll get to it,
there are a lot of things we want to add to the console :)

I suspect we will end up splitting that card into several smaller stories
and do a few of those use cases before we do others.

On Fri, Sep 25, 2015 at 11:01 AM, Kenjiro Nakayama <notifications@github.com

wrote:

Thank you! It will not contain this PR, but it seems that it will
implement soon (via another PR(?)). That's great.

—
Reply to this email directly or view it on GitHub
#4684 (comment).

@spadgett
Copy link
Member Author

spadgett commented Sep 25, 2015

Rebased.

@spadgett
Copy link
Member Author

spadgett commented Sep 25, 2015

Rebased again.

@jwforres
Copy link
Member

jwforres commented Sep 25, 2015

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 25, 2015

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3399/) (Image: devenv-fedora_2404)

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 25, 2015

Evaluated for origin merge up to a7ce0d6

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 25, 2015

Evaluated for origin test up to a7ce0d6

openshift-bot pushed a commit that referenced this pull request Sep 25, 2015
Merge pull request #4684 from spadgett/create-flow-changes
e861080 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit e861080 into openshift:master Sep 25, 2015
@spadgett spadgett deleted the create-flow-changes branch January 9, 2017 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@spadgett @ajacobs21e @jwforres @liggitt @sspeiche @openshift-bot @nak3