Connect the node to the master via the API#797
Connect the node to the master via the API#797openshift-bot merged 5 commits intoopenshift:masterfrom
Conversation
|
Tested it myself, but need to ensure the ansible scripts are setup. I've exposed .kubeconfig as an argument and env var to |
|
This in theory allows us to run on top of GKE |
pkg/cmd/server/kubernetes/node.go
Outdated
There was a problem hiding this comment.
If we're providing a client, do we still need MasterHost?
There was a problem hiding this comment.
Does the kubelet hand this client off to child pods or controllers? We probably want to nip that in the bud, or at least stub out helper methods so we can distribute clients with more scoped permissions later
There was a problem hiding this comment.
No, it's just used for pods and sending events
On Jan 29, 2015, at 8:04 PM, Jordan Liggitt notifications@github.com wrote:
In pkg/cmd/server/kubernetes/node.go:
@@ -46,8 +50,14 @@ type NodeConfig struct {
// The image used as the Kubelet network namespace and volume container.
NetworkContainerImage string
- // A client to connect to etcd
- EtcdClient *etcd.Client
- // Whether to enable TLS serving
- TLS bool
- KubeletCertFile string
- KubeletKeyFile string
- // A client to connect to the master.
- Client *client.Client
Does the kubelet hand this client off to child pods or controllers? We probably want to nip that in the bud, or at least stub out helper methods so we can distribute clients with more scoped permissions later—
Reply to this email directly or view it on GitHub.
8b7c846 to
50e26ec
Compare
|
This is ready for final review - when this lands, it will change how nodes have to be configured. |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/757/) (Image: devenv-fedora_652) |
…cde29367146ae8b389b
Conflicts: Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/master/master.go
Includes changes from Jhon Honce, Mark Turansky, and David Eads
Prepare, but do not enable, the Kubelet to serve over TLS as well.
50e26ec to
4aec0c5
Compare
|
Evaluated for origin up to 4aec0c5 |
|
[merge] |
Merged by openshift-bot
Prepare, but do not enable, the Kubelet to serve over TLS as well.
@brenton @jwhonce @liggitt this removes the need for the nodes to talk to etcd