Skip to content

Connect the node to the master via the API#797

Merged
openshift-bot merged 5 commits intoopenshift:masterfrom
smarterclayton:wire_up_api_to_node
Jan 31, 2015
Merged

Connect the node to the master via the API#797
openshift-bot merged 5 commits intoopenshift:masterfrom
smarterclayton:wire_up_api_to_node

Conversation

@smarterclayton
Copy link
Contributor

Prepare, but do not enable, the Kubelet to serve over TLS as well.

@brenton @jwhonce @liggitt this removes the need for the nodes to talk to etcd

@smarterclayton
Copy link
Contributor Author

Tested it myself, but need to ensure the ansible scripts are setup. I've exposed .kubeconfig as an argument and env var to openshift start, and openshift start node or openshift start master --kubernetes=<> will use that file to connect to the master. When running an all in one that file is ignored.

@smarterclayton
Copy link
Contributor Author

This in theory allows us to run on top of GKE

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're providing a client, do we still need MasterHost?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the kubelet hand this client off to child pods or controllers? We probably want to nip that in the bud, or at least stub out helper methods so we can distribute clients with more scoped permissions later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's just used for pods and sending events

On Jan 29, 2015, at 8:04 PM, Jordan Liggitt notifications@github.com wrote:

In pkg/cmd/server/kubernetes/node.go:

@@ -46,8 +50,14 @@ type NodeConfig struct {
// The image used as the Kubelet network namespace and volume container.
NetworkContainerImage string

  • // A client to connect to etcd
  • EtcdClient *etcd.Client
  • // Whether to enable TLS serving
  • TLS bool
  • KubeletCertFile string
  • KubeletKeyFile string
  • // A client to connect to the master.
  • Client *client.Client
    Does the kubelet hand this client off to child pods or controllers? We probably want to nip that in the bud, or at least stub out helper methods so we can distribute clients with more scoped permissions later


Reply to this email directly or view it on GitHub.

@smarterclayton smarterclayton force-pushed the wire_up_api_to_node branch 2 times, most recently from 8b7c846 to 50e26ec Compare January 30, 2015 16:00
@smarterclayton smarterclayton changed the title WIP - Connect the node to the master via and a built in client Connect the node to the master via and a built in client Jan 30, 2015
@smarterclayton
Copy link
Contributor Author

This is ready for final review - when this lands, it will change how nodes have to be configured.

@smarterclayton smarterclayton changed the title Connect the node to the master via and a built in client Connect the node to the master via a built in client Jan 30, 2015
@smarterclayton smarterclayton changed the title Connect the node to the master via a built in client Connect the node to the master via the API Jan 30, 2015
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/757/) (Image: devenv-fedora_652)

jwhonce and others added 5 commits January 30, 2015 19:23
Conflicts:
	Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/master/master.go
Includes changes from Jhon Honce, Mark Turansky, and David Eads
Prepare, but do not enable, the Kubelet to serve over TLS as well.
@openshift-bot
Copy link
Contributor

Evaluated for origin up to 4aec0c5

@smarterclayton
Copy link
Contributor Author

[merge]

openshift-bot pushed a commit that referenced this pull request Jan 31, 2015
@openshift-bot openshift-bot merged commit 23a0a82 into openshift:master Jan 31, 2015
@smarterclayton smarterclayton deleted the wire_up_api_to_node branch May 18, 2015 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants