Closed
Conversation
Author
|
[test] |
Author
|
resolves #867 |
Author
|
@smarterclayton @pmorie PTAL |
Contributor
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/968/) |
pweil-
force-pushed
the
router-int-pull
branch
from
3d3601f to
ef09cd3
Compare
pweil-
force-pushed
the
router-int-pull
branch
from
ef09cd3 to
855186f
Compare
Contributor
|
Evaluated for origin up to 855186f |
Contributor
There was a problem hiding this comment.
Why not just fail hard here?
Author
There was a problem hiding this comment.
It was failing hard. I added this in so it wouldn't. If we're ok with the failure then this PR can be closed.
Contributor
There was a problem hiding this comment.
I think it's ok if it fails hard, and it's clear why.
----- Original Message -----
@@ -233,6 +233,12 @@ func createAndStartRouterContainer(dockerCli
*dockerClient.Client, masterIp stri
},
}
- err = pullIfNotPresent(dockerCli, getRouterImage())
It was failing hard. I added this in so it wouldn't. If we're ok with the
failure then this PR can be closed.
Reply to this email directly or view it on GitHub:
https://github.com/openshift/origin/pull/879/files#r24108382
Author
There was a problem hiding this comment.
10-4, closing. It would give a message that the image didn't exist.
jpeeler
pushed a commit
to jpeeler/origin
that referenced
this pull request
Jun 15, 2017
…service-catalog/' changes from c91fecb..1bfff53 1bfff53 instance never provisioned should just delete (openshift#891) 1ae26db Adding a fake broker server (openshift#928) 6403076 docs: fix quoting issue, clarify naming in auth.md (openshift#931) 8ac0775 Merge branch 'pr/927' 02af952 Merge branch 'pr/876' 2aa84f9 add Jenkins badge to README 0c08788 Brokers must have at least one service (openshift#930) cbfa39b Add PodPreset support (openshift#917) 0d9b810 refactor Jenkins GitHub status postback to work on non-PR commits (openshift#916) 066159d Converting the AuthSecret field to a union AuthInfo type (openshift#877) 203af5c Add leader election namespace configuration (openshift#920) 5831502 Add example JSON schema to controller unit tests (openshift#918) b78ab99 Fix usage of finalizers (openshift#894) d3d29f0 Enable pprof in controller-manager (openshift#896) f4233a0 Correct parameter schema support (openshift#912) 05c6f00 bump image tags from v0.0.8 to v0.0.9 (openshift#910) 97d278a Add support for OSB parameter schemas (openshift#822) 3e4120e Fix nil dereference panic on request timeout (openshift#906) d8c7494 Add feature gate for audit options in helm chart (openshift#904) 89ce1cd Decompose controller unit tests (openshift#899) a1e83b2 Add e2e for walkthrough (openshift#832) 4679685 Add support for audit log options (openshift#897) 262a94f Do not allow updates to an object if asynchronous operation is in progress (openshift#853) 7295dad Validate that a ServiceClass must have at least one plan (openshift#879) 9db9fa4 Decompose controller.go (openshift#893) c3ea9bd Nits in our types (openshift#854) 1d8280a bump tags from v0.0.7 to v0.0.8 (openshift#892) 5e6925d Clean up the OSB client (openshift#888) fe6aee9 cleaning up logs and adding more log detail (openshift#874) f41516f Detect if a TPR update represents a soft delete (openshift#836) 9ce99f3 Add functions on Makefile for build and tag REVERT: c91fecb Merge pull request openshift#1 from jpeeler/origin-build REVERT: 55ccf3d origin build: add _output to .gitignore REVERT: 8352e14 origin build: make build-go and build-cross work REVERT: d969641 origin build: modify hard coded path REVERT: 30000cc origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: 1bfff53
jpeeler
pushed a commit
to jpeeler/origin
that referenced
this pull request
Jun 15, 2017
…service-catalog/' changes from c91fecb..568a7b9 568a7b9 origin build: add origin tooling 1bfff53 instance never provisioned should just delete (openshift#891) 1ae26db Adding a fake broker server (openshift#928) 6403076 docs: fix quoting issue, clarify naming in auth.md (openshift#931) 8ac0775 Merge branch 'pr/927' 02af952 Merge branch 'pr/876' 2aa84f9 add Jenkins badge to README 0c08788 Brokers must have at least one service (openshift#930) cbfa39b Add PodPreset support (openshift#917) 0d9b810 refactor Jenkins GitHub status postback to work on non-PR commits (openshift#916) 066159d Converting the AuthSecret field to a union AuthInfo type (openshift#877) 203af5c Add leader election namespace configuration (openshift#920) 5831502 Add example JSON schema to controller unit tests (openshift#918) b78ab99 Fix usage of finalizers (openshift#894) d3d29f0 Enable pprof in controller-manager (openshift#896) f4233a0 Correct parameter schema support (openshift#912) 05c6f00 bump image tags from v0.0.8 to v0.0.9 (openshift#910) 97d278a Add support for OSB parameter schemas (openshift#822) 3e4120e Fix nil dereference panic on request timeout (openshift#906) d8c7494 Add feature gate for audit options in helm chart (openshift#904) 89ce1cd Decompose controller unit tests (openshift#899) a1e83b2 Add e2e for walkthrough (openshift#832) 4679685 Add support for audit log options (openshift#897) 262a94f Do not allow updates to an object if asynchronous operation is in progress (openshift#853) 7295dad Validate that a ServiceClass must have at least one plan (openshift#879) 9db9fa4 Decompose controller.go (openshift#893) c3ea9bd Nits in our types (openshift#854) 1d8280a bump tags from v0.0.7 to v0.0.8 (openshift#892) 5e6925d Clean up the OSB client (openshift#888) fe6aee9 cleaning up logs and adding more log detail (openshift#874) f41516f Detect if a TPR update represents a soft delete (openshift#836) 9ce99f3 Add functions on Makefile for build and tag REVERT: c91fecb Merge pull request openshift#1 from jpeeler/origin-build REVERT: 55ccf3d origin build: add _output to .gitignore REVERT: 8352e14 origin build: make build-go and build-cross work REVERT: d969641 origin build: modify hard coded path REVERT: 30000cc origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: 568a7b9dbdc4fdd1fabffdd52af030ec73124b89
jpeeler
pushed a commit
to jpeeler/origin
that referenced
this pull request
Feb 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add code to pull the router image if it is not present. Updated docker script to add a longer (than 45s) timeout to account for a pull.
Beta1 item