Tutorial for creating an application and build on openshift v3 by bparees · Pull Request #94 · openshift/origin

bparees · 2014-09-16T18:37:04Z

This tutorial will continue to evolve to include things like deployments, deployment triggers, and private docker registries.

bparees · 2014-09-16T18:38:11Z

@smarterclayton do your worst.....

smarterclayton · 2014-09-16T20:36:29Z

I'll be sure to wait until I get a few beers in me first.

soltysh · 2014-09-17T14:41:45Z

You should reformat that one, as it looks terrible when parsed by github markdown. The problem seems to be with * lines.

thanks, fixed.

ironcladlou · 2014-09-18T01:46:26Z

s/Openshift/OpenShift/g

smarterclayton · 2014-09-18T15:55:02Z

Rename origin_ruby_sample to origin-ruby-sample in here and on github. This makes my eyes bleed :)

bparees · 2014-09-18T16:47:20Z

@smarterclayton grumble. _ is more universally accepted in identifiers than - (eg in docker tags) which is why i used it.

smarterclayton · 2014-09-18T16:56:11Z

We don't name any of our other github repos with underscores, which is why I push on it :)

On Sep 18, 2014, at 12:47 PM, Ben Parees notifications@github.com wrote:

@smarterclayton grumble. _ is more universally accepted in identifiers than - (eg in docker tags) which is why i used it.

—
Reply to this email directly or view it on GitHub.

bparees · 2014-09-18T16:58:24Z

@smarterclayton s/don't/didn't/g. embrace change!

bparees · 2014-09-18T19:41:41Z

@smarterclayton ok I think i've addressed all comments except the cleanup/deletion issue, which as I noted, we'll continue to evolve towards over time.

ironcladlou · 2014-09-18T21:04:39Z

@bparees Heads up: I'm pushing for #111 which shouldn't break anything here, but which would let you remove the use of USE_HOST_DOCKER_SOCKET. Minor, but it's something I noticed.

smarterclayton · 2014-09-19T14:38:57Z

When referencing the binary use openshift (back ticks), and capitalize Docker everywhere except CLI statements.

bparees · 2014-09-19T16:47:11Z

Ok I think i've corrected everything on your list.

smarterclayton · 2014-09-19T18:18:03Z

LGTM [merge]

openshift-bot · 2014-09-19T18:23:15Z

Origin Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/113/) (Image: devenv-fedora_180)

openshift-bot · 2014-09-19T18:23:15Z

Evaluated for origin up to 9e32876

Merged by openshift-bot

Added repository name for yum repos and fixed permission/timestamp issue with go packages

Allocation -> Scheduling

separate quota evaluation for admission versus reconciliation

bparees force-pushed the sample_app branch 3 times, most recently from 9f1eb2f to e4f74e4 Compare September 16, 2014 19:44

bparees force-pushed the sample_app branch from e4f74e4 to 93cfa1f Compare September 16, 2014 20:55

soltysh reviewed Sep 17, 2014
View reviewed changes

bparees force-pushed the sample_app branch 3 times, most recently from 72d2e18 to 5fdba07 Compare September 17, 2014 18:31

ironcladlou reviewed Sep 18, 2014
View reviewed changes

bparees force-pushed the sample_app branch 9 times, most recently from 15a977b to 262983e Compare September 18, 2014 19:23

bparees force-pushed the sample_app branch 10 times, most recently from 0629b79 to 58d1a77 Compare September 18, 2014 19:40

bparees force-pushed the sample_app branch 5 times, most recently from 202843a to bdf2ffa Compare September 18, 2014 20:18

smarterclayton reviewed Sep 19, 2014
View reviewed changes

initial create of example of application creation flow

9e32876

bparees force-pushed the sample_app branch from bdf2ffa to 9e32876 Compare September 19, 2014 15:19

openshift-bot pushed a commit that referenced this pull request Sep 19, 2014

Merge pull request #94 from bparees/sample_app

92b2a99

Merged by openshift-bot

openshift-bot merged commit 92b2a99 into openshift:master Sep 19, 2014

bparees deleted the sample_app branch October 20, 2014 17:17

pmorie referenced this pull request in pmorie/origin Nov 5, 2014

Merge pull request #94 from mfojtik/repo_name

8e694c4

Added repository name for yum repos and fixed permission/timestamp issue with go packages

pweil- pushed a commit to pweil-/origin that referenced this pull request Dec 2, 2014

Merge pull request openshift#94 from pmorie/router-shards-proposal-wip

fbfd83c

Allocation -> Scheduling

ncdc pushed a commit to ncdc/origin that referenced this pull request Apr 25, 2017

Merge pull request openshift#94 from deads2k/rebase-02

8d7e313

separate quota evaluation for admission versus reconciliation

Conversation

bparees commented Sep 16, 2014

Uh oh!

bparees commented Sep 16, 2014

Uh oh!

smarterclayton commented Sep 16, 2014

Uh oh!

soltysh Sep 17, 2014

Choose a reason for hiding this comment

Uh oh!

bparees Sep 17, 2014

Choose a reason for hiding this comment

Uh oh!

ironcladlou Sep 18, 2014

Choose a reason for hiding this comment

Uh oh!

bparees Sep 18, 2014

Choose a reason for hiding this comment

Uh oh!

smarterclayton commented Sep 18, 2014

Uh oh!

bparees commented Sep 18, 2014

Uh oh!

smarterclayton commented Sep 18, 2014

Uh oh!

bparees commented Sep 18, 2014

Uh oh!

bparees commented Sep 18, 2014

Uh oh!

ironcladlou commented Sep 18, 2014

Uh oh!

smarterclayton Sep 19, 2014

Choose a reason for hiding this comment

Uh oh!

bparees Sep 19, 2014

Choose a reason for hiding this comment

Uh oh!

bparees commented Sep 19, 2014

Uh oh!

smarterclayton commented Sep 19, 2014

Uh oh!

openshift-bot commented Sep 19, 2014

Uh oh!

openshift-bot commented Sep 19, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants