Package up install-router.sh for inclusion in RPMs#969
Package up install-router.sh for inclusion in RPMs#969sdodson wants to merge 1 commit intoopenshift:masterfrom
Conversation
This is temporary
|
@pweil- and @sosiouxme relevant to your interests |
|
Need the same thing for the docker registry (so it can alert the master when it gets updated images). https://github.com/openshift/origin/blob/master/hack/install-registry.sh |
|
I'm starting to think we should just convert this to use getopts. The next person that has another file/cert/whatever is going to run into the same trouble but What do you think @sosiouxme @thoraxe @sdodson? |
|
It would be nice if you could specify files and other things on the cli, and have the script automatically ingest them and turn them into appropriate vars. |
|
I was going to suggest that we convert We could just keep adding things to /etc/sysconfig/openshift and have scripts source that file if it exists and has the variable we want otherwise use script local defaults. This may be nice because it would promote re-use, i hope, perhaps not in practice. |
|
Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again |
|
#1053 removes the need for this pull. Router installation is a separate command, and hack/install-router is gone. |
|
#1043 Is the correct PR for the router command |
This is temporary. If we're looking for this to be a complete solution for OSE we'll also need to modify the image name.