Node image: need to include repos based on OS `ID` and `VERSION_ID`

[joelcapitao]

To build node image, we currently include repos based on id as per:

os/packages-openshift.yaml

Lines 7 to 24 in 9b587eb

	conditional-include:
	- if: id == "rhel"
	include:
	repos:
	- rhel-9.6-baseos
	- rhel-9.6-appstream
	- rhel-9.6-early-kernel
	- rhel-9.6-fast-datapath
	- rhel-9.6-server-ose-4.19
	- if: id == "centos"
	include:
	repos:
	- c9s-baseos
	- c9s-appstream
	- c9s-sig-nfv
	- c9s-sig-cloud-okd
	# XXX: this shouldn't be here; see related XXX in Containerfile
	- rhel-9.6-server-ose-4.19-okd

and the value is passed with:

os/build-node-image.sh

Lines 37 to 38 in 9b587eb

	rpm-ostree experimental compose treefile-apply \
	--var id=$ID /run/src/packages-openshift.yaml

itself based on :

os/build-node-image.sh

Line 20 in 9b587eb

source /etc/os-release

We would need to use the env var VERSION_ID as condition as well in order to be able to build for EL10 with the right repos.

Based on this commit message coreos/rpm-ostree@99aff16 @jlebon tempted to implement --var-from-os-release as parameter when using treefile-apply, but decided to go with current solution to get #1498 merged quickly.
I think implementing --var-from-os-release should be the way to go for long-term solution.
For short-term, maybe we should pass the required values in id var as per: --var id="${ID}_${VERSION_ID}", and edit the conditional-include list by adding the rhel_9, rhel_10, centos_9 and centos_10 entries.

What are your thoughts on this ?

[joelcapitao]

I just came across this commit dustymabe@8809850 which is quite the same implementation but with a better wording
I will propose the same for the OKD nodeimage

[jbtrystram]

Some context in 4044a42 as well as the original idea from jlebon: #1786 (comment)