Skip to content

common-el9: Make nvmf dracut script executable#1094

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cgwalters:make-nvmf-executable
Dec 12, 2022
Merged

common-el9: Make nvmf dracut script executable#1094
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cgwalters:make-nvmf-executable

Conversation

@cgwalters
Copy link
Copy Markdown
Member

Closes: #942

@openshift-ci openshift-ci Bot requested review from HuijingHei and jlebon December 12, 2022 15:15
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
Comment thread common-el9.yaml Outdated
ln -sr /usr/share/zoneinfo/UTC /etc/localtime
- |
#!/usr/bin/env bash
set -xeo pipefail
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: doesn't matter in this case, but this is missing the classic u. Was that on purpose?

@cgwalters cgwalters force-pushed the make-nvmf-executable branch from 1a2dfed to 037edba Compare December 12, 2022 16:10
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Dec 12, 2022

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2022
@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD e7b412b and 2 for PR HEAD 037edba in total

@cgwalters
Copy link
Copy Markdown
Member Author

/override ci/prow/scos-9-build-test-qemu

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 12, 2022

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/scos-9-build-test-qemu

Details

In response to this:

/override ci/prow/scos-9-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 1cb9a53 into openshift:master Dec 12, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 12, 2022

@cgwalters: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RHCOS9: ext.config.shared.files.dracut-executable

4 participants