Skip to content

manifest/9.2: Ensure package come from RHEL by default#1188

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
travier:appstream-rhcos-packages
Mar 13, 2023
Merged

manifest/9.2: Ensure package come from RHEL by default#1188
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
travier:appstream-rhcos-packages

Conversation

@travier
Copy link
Copy Markdown
Member

@travier travier commented Mar 9, 2023

Make sure that we use RHEL (and not RHAOS) packages by default.

@openshift-ci openshift-ci Bot requested review from HuijingHei and jlebon March 9, 2023 14:12
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2023
@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 9, 2023

ignition-2.15.0-1.el9.x86_64 (appstream)

This one is using the right version of Ignition

@jlebon
Copy link
Copy Markdown
Member

jlebon commented Mar 9, 2023

Seems sane, but is there a misconfiguration or bug here? Why aren't we already picking the highest NEVRA?

/approve

@cgwalters
Copy link
Copy Markdown
Member

I'm confused, in #1187 we are using this version of Ignition and we are hitting that linked bug.

@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 9, 2023

Hum, indeed. That's weird

@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 10, 2023

/retest

@travier travier force-pushed the appstream-rhcos-packages branch from bf09666 to 01d2dad Compare March 10, 2023 09:22
@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 10, 2023

OK so now this fails in 8.6 which does not have the new Ignition.

@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 10, 2023

Cleaning things in #1189

Make sure that we use RHEL (and not RHAOS) packages by default.
@travier travier force-pushed the appstream-rhcos-packages branch from 01d2dad to 49f9824 Compare March 10, 2023 18:01
@HuijingHei
Copy link
Copy Markdown
Contributor

/LGTM

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuijingHei, jlebon, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [HuijingHei,jlebon,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 13, 2023

@travier: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d34fbde into openshift:master Mar 13, 2023
@travier travier deleted the appstream-rhcos-packages branch March 13, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants