Skip to content

[release-4.13] OCPBUGS-11657: Bump fedora-coreos-config#1249

Merged
openshift-merge-robot merged 3 commits intoopenshift:release-4.13from
ravanelli:bz_2176212
Apr 12, 2023
Merged

[release-4.13] OCPBUGS-11657: Bump fedora-coreos-config#1249
openshift-merge-robot merged 3 commits intoopenshift:release-4.13from
ravanelli:bz_2176212

Conversation

@ravanelli
Copy link
Copy Markdown
Member

@ravanelli ravanelli commented Apr 10, 2023

Dusty Mabe (1):
coreos-teardown-initramfs: teardown after NM has exited

Renata Ravanelli (3):
overlay.d: create new 30gcp-udev-rules overlay
overlay.d: Add/Update udev rules for GCP
Add 30gcp-udev-rules overlay to the manifest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 10, 2023

@ravanelli: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Bump fedora-coreos-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from ashcrow and jlebon April 10, 2023 13:16
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2023
@ravanelli
Copy link
Copy Markdown
Member Author

/hold
It is still missing the manifest update

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 11, 2023

@ravanelli: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Bump fedora-coreos-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ravanelli
Copy link
Copy Markdown
Member Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2023
@dustymabe dustymabe changed the title Bump fedora-coreos-config OCPBUGS-11052: Bump fedora-coreos-config Apr 11, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 11, 2023

@ravanelli: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-11052: Bump fedora-coreos-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 11, 2023
@openshift-ci-robot
Copy link
Copy Markdown

@ravanelli: This pull request references Jira Issue OCPBUGS-11052, which is invalid:

  • expected Jira Issue OCPBUGS-11052 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Dusty Mabe (1):
coreos-teardown-initramfs: teardown after NM has exited

Renata Ravanelli (3):
overlay.d: create new 30gcp-udev-rules overlay
overlay.d: Add/Update udev rules for GCP
Add 30gcp-udev-rules overlay to the manifest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dustymabe dustymabe changed the title OCPBUGS-11052: Bump fedora-coreos-config Bump fedora-coreos-config Apr 11, 2023
@openshift-ci-robot openshift-ci-robot removed jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 11, 2023
@openshift-ci-robot
Copy link
Copy Markdown

@ravanelli: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Dusty Mabe (1):
coreos-teardown-initramfs: teardown after NM has exited

Renata Ravanelli (3):
overlay.d: create new 30gcp-udev-rules overlay
overlay.d: Add/Update udev rules for GCP
Add 30gcp-udev-rules overlay to the manifest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 11, 2023

@ravanelli: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Bump fedora-coreos-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dustymabe dustymabe changed the title Bump fedora-coreos-config OCPBUGS-11657: Bump fedora-coreos-config Apr 11, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 11, 2023

@ravanelli: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-11657: Bump fedora-coreos-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 11, 2023
@openshift-ci-robot
Copy link
Copy Markdown

@ravanelli: This pull request references Jira Issue OCPBUGS-11657, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-11052 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-11052 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Dusty Mabe (1):
coreos-teardown-initramfs: teardown after NM has exited

Renata Ravanelli (3):
overlay.d: create new 30gcp-udev-rules overlay
overlay.d: Add/Update udev rules for GCP
Add 30gcp-udev-rules overlay to the manifest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from mike-nguyen April 11, 2023 15:30
@mike-nguyen
Copy link
Copy Markdown
Member

/label cherry-pick-approved
/label backport-risk-assessed

@openshift-ci openshift-ci Bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Apr 11, 2023
@ravanelli
Copy link
Copy Markdown
Member Author

/test scos-9-build-test-metal
/test scos-9-build-test-qemu

@dustymabe
Copy link
Copy Markdown
Member

Are secureboot tests known to be failing? Last two runs show:

 Running test: iso-as-disk.uefi-secure
FAIL: iso-as-disk.uefi-secure (10m0s)
    timed out after 10m0s
Running test: iso-as-disk.4k.uefi
PASS: iso-as-disk.4k.uefi (42.912s)
Running test: iso-install.bios
PASS: iso-install.bios (4m30.114s)
Running test: iso-live-login.bios
PASS: iso-live-login.bios (1m5.104s)
Running test: iso-live-login.uefi
PASS: iso-live-login.uefi (55.286s)
Running test: iso-live-login.uefi-secure
FAIL: iso-live-login.uefi-secure (10m0.003s)
    timed out after 10m0s 

and:

 === RUN   basic
--- FAIL: basic (601.54s)
        harness.go:103: TIMEOUT[10m0s]: SSH unsuccessful within allotted timeframe for 55a62969-9ecf-46b1-b090-ddabd38a2043.
FAIL, output in /logs/artifacts/kola
Error: harness: test suite failed
2023-04-11T16:24:51Z cli: harness: test suite failed
Traceback (most recent call last):
  File "/usr/lib/coreos-assembler/cmd-kola", line 75, in <module>
    subprocess.check_call(subargs)
  File "/usr/lib64/python3.11/subprocess.py", line 413, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['kola', '-p', 'qemu-unpriv', '--output-dir', '/logs/artifacts/kola', 'run', '--qemu-firmware=uefi-secure', 'basic', '--qemu-memory', '1536']' returned non-zero exit status 1.
error: failed to execute cmd-kola: exit status 1
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"k8s.io/test-infra/prow/entrypoint/run.go:79","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2023-04-11T16:24:51Z"}

@jlebon
Copy link
Copy Markdown
Member

jlebon commented Apr 11, 2023

Hmm, I think we need to backport #1238 to release-4.13?
Probably easier to inline it into this PR.

@jlebon jlebon changed the title OCPBUGS-11657: Bump fedora-coreos-config [release-4.13] OCPBUGS-11657: Bump fedora-coreos-config Apr 11, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 11, 2023

@ravanelli: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

Details

In response to this:

[release-4.13] OCPBUGS-11657: Bump fedora-coreos-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dustymabe
Copy link
Copy Markdown
Member

Hmm, I think we need to backport #1238 to release-4.13? Probably easier to inline it into this PR.

Yep. Will do.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2023
Dusty Mabe (1):
      coreos-teardown-initramfs: teardown after NM has exited

Renata Ravanelli (3):
      overlay.d: create new 30gcp-udev-rules overlay
      overlay.d: Add/Update udev rules for GCP
      Add 30gcp-udev-rules overlay to the manifest

Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2023
@dustymabe
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2023
@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 8876c2c and 2 for PR HEAD 1cbfc8e in total

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD cbcfd93 and 1 for PR HEAD 1cbfc8e in total

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2023
@dustymabe
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, ravanelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dustymabe,ravanelli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 12, 2023

@ravanelli: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f80a74e into openshift:release-4.13 Apr 12, 2023
@openshift-ci-robot
Copy link
Copy Markdown

@ravanelli: Jira Issue OCPBUGS-11657: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11657 has been moved to the MODIFIED state.

Details

In response to this:

Dusty Mabe (1):
coreos-teardown-initramfs: teardown after NM has exited

Renata Ravanelli (3):
overlay.d: create new 30gcp-udev-rules overlay
overlay.d: Add/Update udev rules for GCP
Add 30gcp-udev-rules overlay to the manifest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants