OCPBUGS-11124, OCPBUGS-11411: overlay: Mask pcrphase service#1280
OCPBUGS-11124, OCPBUGS-11411: overlay: Mask pcrphase service#1280mkowalski wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test all |
openshift-ci-robot
added
jira/severity-critical
|
@mkowalski: This pull request references Jira Issue OCPBUGS-11411, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mkowalski The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc @jlebon Can you take a look if this way of masking a service will work in the assembly? |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
| EOF | ||
|
|
||
| # Tweak dependencies of systemd-user-sessions.service to not rely on network. | ||
| # Copy file to /etc because /usr is a read-only filesystem. |
There was a problem hiding this comment.
No. In this case we're doing this at build time to generate the content in /usr.
So we absolutely can just directly edit the file in /usr, and that's probably the better thing to do even.
There was a problem hiding this comment.
(This is a fundamental difference between doing a PR for this repository versus e.g. https://github.com/openshift/machine-config-operator/ - the latter case is "configuration" that is lifecycled outside of the OS and lives in /etc or /var mostly; the content here goes in /usr)
In a layering world, this is unified because it's equally easy to drop higher level content in /usr too.
There was a problem hiding this comment.
Oh this is great, makes it even easier for me then. Just fixed and now I modify directly in /usr
This PR masks systemd-pcrphase service which is not used at the moment. Its existence creates issues as it depends on the remote-fs and as a consequence blocks access to the system if network configuration is not correct. Anyway in OpenShift we are not using remote home directories, so this would not be useful for us. We are also modifying dependencies of systemd-user-sessions.service so that we are explicitly saying that we do not need network in order to allow access to the node. Fixes: OCPBUGS-11124 Fixes: OCPBUGS-11411
|
@mkowalski: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I think this is also superseded by #1294. |
|
/close Indeed #1294 is solving the issue |
|
@mkowalski: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mkowalski: This pull request references Jira Issue OCPBUGS-11411. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
This PR masks systemd-pcrphase service which is not used at the moment. Its existence creates issues as it depends on the remote-fs and as a consequence blocks access to the system if network configuration is not correct.
Anyway in OpenShift we are not using remote home directories, so this would not be useful for us.
We are also modifying dependencies of systemd-user-sessions.service so that we are explicitly saying that we do not need network in order to allow access to the node.
Fixes: OCPBUGS-11124
Fixes: OCPBUGS-11411